Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: components/sync_driver/non_ui_data_type_controller_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/non_ui_data_type_controller_unittest.cc
diff --git a/components/sync_driver/non_ui_data_type_controller_unittest.cc b/components/sync_driver/non_ui_data_type_controller_unittest.cc
index e8bef60d2d92d0e0df4e38c83454fc23ab469b09..61f63046744322207cec7d1589f442776e2c9384 100644
--- a/components/sync_driver/non_ui_data_type_controller_unittest.cc
+++ b/components/sync_driver/non_ui_data_type_controller_unittest.cc
@@ -106,10 +106,8 @@ class NonUIDataTypeControllerFake
change_processor_(change_processor),
backend_loop_(backend_loop) {}
- virtual syncer::ModelType type() const override {
- return AUTOFILL_PROFILE;
- }
- virtual syncer::ModelSafeGroup model_safe_group() const override {
+ syncer::ModelType type() const override { return AUTOFILL_PROFILE; }
+ syncer::ModelSafeGroup model_safe_group() const override {
return syncer::GROUP_DB;
}
@@ -130,14 +128,13 @@ class NonUIDataTypeControllerFake
pending_tasks_.clear();
}
- virtual SharedChangeProcessor* CreateSharedChangeProcessor() override {
+ SharedChangeProcessor* CreateSharedChangeProcessor() override {
return change_processor_.get();
}
protected:
- virtual bool PostTaskOnBackendThread(
- const tracked_objects::Location& from_here,
- const base::Closure& task) override {
+ bool PostTaskOnBackendThread(const tracked_objects::Location& from_here,
+ const base::Closure& task) override {
if (blocked_) {
pending_tasks_.push_back(PendingTask(from_here, task));
return true;
@@ -148,22 +145,17 @@ class NonUIDataTypeControllerFake
// We mock the following methods because their default implementations do
// nothing, but we still want to make sure they're called appropriately.
- virtual bool StartModels() override {
- return mock_->StartModels();
- }
- virtual void StopModels() override {
- mock_->StopModels();
- }
- virtual void RecordAssociationTime(base::TimeDelta time) override {
+ bool StartModels() override { return mock_->StartModels(); }
+ void StopModels() override { mock_->StopModels(); }
+ void RecordAssociationTime(base::TimeDelta time) override {
mock_->RecordAssociationTime(time);
}
- virtual void RecordStartFailure(DataTypeController::ConfigureResult result)
- override {
+ void RecordStartFailure(DataTypeController::ConfigureResult result) override {
mock_->RecordStartFailure(result);
}
private:
- virtual ~NonUIDataTypeControllerFake() {}
+ ~NonUIDataTypeControllerFake() override {}
DISALLOW_COPY_AND_ASSIGN(NonUIDataTypeControllerFake);
« no previous file with comments | « components/sync_driver/non_ui_data_type_controller.h ('k') | components/sync_driver/proxy_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698