components/storage_monitor/storage_monitor.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/storage_monitor.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/storage_monitor/mock_removable_storage_observer.h ('k') | components/storage_monitor/storage_monitor_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/storage_monitor.cc

diff --git a/components/storage_monitor/storage_monitor.cc b/components/storage_monitor/storage_monitor.cc

index cd6bfae51327366d1c0b01d807b8126cb5fbe13a..f82995d81a7d57accdfce3963522ab9c344da09d 100644

--- a/components/storage_monitor/storage_monitor.cc

+++ b/components/storage_monitor/storage_monitor.cc

@@ -25,13 +25,13 @@ class StorageMonitor::ReceiverImpl : public StorageMonitor::Receiver {

explicit ReceiverImpl(StorageMonitor* notifications)

: notifications_(notifications) {}

- virtual ~ReceiverImpl() {}

+ ~ReceiverImpl() override {}

- virtual void ProcessAttach(const StorageInfo& info) override;

+ void ProcessAttach(const StorageInfo& info) override;

- virtual void ProcessDetach(const std::string& id) override;

+ void ProcessDetach(const std::string& id) override;

- virtual void MarkInitialized() override;

+ void MarkInitialized() override;

private:

StorageMonitor* notifications_;

« no previous file with comments | « components/storage_monitor/mock_removable_storage_observer.h ('k') | components/storage_monitor/storage_monitor_mac.h » ('j') | no next file with comments »