Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: components/signin/core/browser/test_signin_client.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/test_signin_client.h
diff --git a/components/signin/core/browser/test_signin_client.h b/components/signin/core/browser/test_signin_client.h
index 4df28fa5176038f610169297d171e9875ee2b8c0..1538327c93431c9f585dcf2d14cf9d6b750158f4 100644
--- a/components/signin/core/browser/test_signin_client.h
+++ b/components/signin/core/browser/test_signin_client.h
@@ -26,33 +26,33 @@ class TestSigninClient : public SigninClient {
public:
TestSigninClient();
TestSigninClient(PrefService* pref_service);
- virtual ~TestSigninClient();
+ ~TestSigninClient() override;
// SigninClient implementation that is specialized for unit tests.
// Returns NULL.
// NOTE: This should be changed to return a properly-initalized PrefService
// once there is a unit test that requires it.
- virtual PrefService* GetPrefs() override;
+ PrefService* GetPrefs() override;
// Returns a pointer to a loaded database.
- virtual scoped_refptr<TokenWebData> GetDatabase() override;
+ scoped_refptr<TokenWebData> GetDatabase() override;
// Returns true.
- virtual bool CanRevokeCredentials() override;
+ bool CanRevokeCredentials() override;
// Returns empty string.
- virtual std::string GetSigninScopedDeviceId() override;
+ std::string GetSigninScopedDeviceId() override;
// Does nothing.
- virtual void OnSignedOut() override;
+ void OnSignedOut() override;
// Returns the empty string.
- virtual std::string GetProductVersion() override;
+ std::string GetProductVersion() override;
// Returns a TestURLRequestContextGetter or an manually provided
// URLRequestContextGetter.
- virtual net::URLRequestContextGetter* GetURLRequestContext() override;
+ net::URLRequestContextGetter* GetURLRequestContext() override;
// For testing purposes, can override the TestURLRequestContextGetter created
// in the default constructor.
@@ -63,23 +63,23 @@ class TestSigninClient : public SigninClient {
#endif
// Returns true.
- virtual bool ShouldMergeSigninCredentialsIntoCookieJar() override;
+ bool ShouldMergeSigninCredentialsIntoCookieJar() override;
// Does nothing.
- virtual scoped_ptr<CookieChangedCallbackList::Subscription>
- AddCookieChangedCallback(const CookieChangedCallback& callback) override;
+ scoped_ptr<CookieChangedCallbackList::Subscription> AddCookieChangedCallback(
+ const CookieChangedCallback& callback) override;
#if defined(OS_IOS)
ios::FakeProfileOAuth2TokenServiceIOSProvider* GetIOSProviderAsFake();
#endif
// SigninClient overrides:
- virtual void SetSigninProcess(int host_id) override;
- virtual void ClearSigninProcess() override;
- virtual bool IsSigninProcess(int host_id) const override;
- virtual bool HasSigninProcess() const override;
- virtual bool IsFirstRun() const override;
- virtual base::Time GetInstallDate() override;
+ void SetSigninProcess(int host_id) override;
+ void ClearSigninProcess() override;
+ bool IsSigninProcess(int host_id) const override;
+ bool HasSigninProcess() const override;
+ bool IsFirstRun() const override;
+ base::Time GetInstallDate() override;
private:
// Loads the token database.
« no previous file with comments | « components/signin/core/browser/signin_tracker.h ('k') | components/signin/core/browser/webdata/token_service_table.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698