Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: components/signin/core/browser/signin_oauth_helper.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_oauth_helper.h
diff --git a/components/signin/core/browser/signin_oauth_helper.h b/components/signin/core/browser/signin_oauth_helper.h
index fa361a131a35accbfbda807c8b4725d0bcd86131..12de65bd9caae1fa06df5176f984f1d789ec84ae 100644
--- a/components/signin/core/browser/signin_oauth_helper.h
+++ b/components/signin/core/browser/signin_oauth_helper.h
@@ -38,19 +38,16 @@ class SigninOAuthHelper : public GaiaAuthConsumer {
const std::string& session_index,
const std::string& signin_scoped_device_id,
Consumer* consumer);
- virtual ~SigninOAuthHelper();
+ ~SigninOAuthHelper() override;
private:
// Overridden from GaiaAuthConsumer.
- virtual void OnClientOAuthSuccess(const ClientOAuthResult& result) override;
- virtual void OnClientOAuthFailure(const GoogleServiceAuthError& error)
- override;
- virtual void OnClientLoginSuccess(const ClientLoginResult& result) override;
- virtual void OnClientLoginFailure(const GoogleServiceAuthError& error)
- override;
- virtual void OnGetUserInfoSuccess(const UserInfoMap& data) override;
- virtual void OnGetUserInfoFailure(const GoogleServiceAuthError& error)
- override;
+ void OnClientOAuthSuccess(const ClientOAuthResult& result) override;
+ void OnClientOAuthFailure(const GoogleServiceAuthError& error) override;
+ void OnClientLoginSuccess(const ClientLoginResult& result) override;
+ void OnClientLoginFailure(const GoogleServiceAuthError& error) override;
+ void OnGetUserInfoSuccess(const UserInfoMap& data) override;
+ void OnGetUserInfoFailure(const GoogleServiceAuthError& error) override;
GaiaAuthFetcher gaia_auth_fetcher_;
std::string refresh_token_;
« no previous file with comments | « components/signin/core/browser/signin_manager_base.h ('k') | components/signin/core/browser/signin_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698