Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: components/signin/core/browser/signin_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_manager.h
diff --git a/components/signin/core/browser/signin_manager.h b/components/signin/core/browser/signin_manager.h
index 320872e698506a9b88c741c01ee520cd7f470398..57f38131bd34b513437cdff46f50610b1c71b659 100644
--- a/components/signin/core/browser/signin_manager.h
+++ b/components/signin/core/browser/signin_manager.h
@@ -64,7 +64,7 @@ class SigninManager : public SigninManagerBase {
static const char kChromeSigninEffectiveSite[];
SigninManager(SigninClient* client, ProfileOAuth2TokenService* token_service);
- virtual ~SigninManager();
+ ~SigninManager() override;
// Returns true if the username is allowed based on the policy string.
static bool IsUsernameAllowedByPolicy(const std::string& username,
@@ -93,8 +93,8 @@ class SigninManager : public SigninManagerBase {
// On platforms where SigninManager is responsible for dealing with
// invalid username policy updates, we need to check this during
// initialization and sign the user out.
- virtual void Initialize(PrefService* local_state) override;
- virtual void Shutdown() override;
+ void Initialize(PrefService* local_state) override;
+ void Shutdown() override;
// Invoked from an OAuthTokenFetchedCallback to complete user signin.
virtual void CompletePendingSignin();
@@ -104,9 +104,9 @@ class SigninManager : public SigninManagerBase {
void OnExternalSigninCompleted(const std::string& username);
// Returns true if there's a signin in progress.
- virtual bool AuthInProgress() const override;
+ bool AuthInProgress() const override;
- virtual bool IsSigninAllowed() const override;
+ bool IsSigninAllowed() const override;
// Returns true if the passed username is allowed by policy. Virtual for
// mocking in tests.
« no previous file with comments | « components/signin/core/browser/signin_client.h ('k') | components/signin/core/browser/signin_manager_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698