components/signin/core/browser/signin_account_id_helper.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_account_id_helper.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/profile_oauth2_token_service.h ('k') | components/signin/core/browser/signin_account_id_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/signin_account_id_helper.h

diff --git a/components/signin/core/browser/signin_account_id_helper.h b/components/signin/core/browser/signin_account_id_helper.h

index 680d463990f649fcd589ad02befe5fc4758c11d4..8c938960a1668d9f9b0d06a7e48eb1cb56858b30 100644

--- a/components/signin/core/browser/signin_account_id_helper.h

+++ b/components/signin/core/browser/signin_account_id_helper.h

@@ -24,14 +24,14 @@ class SigninAccountIdHelper : public SigninManagerBase::Observer,

SigninAccountIdHelper(SigninClient* client,

ProfileOAuth2TokenService* token_service,

SigninManagerBase* signin_manager);

- virtual ~SigninAccountIdHelper();

+ ~SigninAccountIdHelper() override;

// SigninManagerBase::Observer:

- virtual void GoogleSignedOut(const std::string& account_id,

- const std::string& username) override;

+ void GoogleSignedOut(const std::string& account_id,

+ const std::string& username) override;

// OAuth2TokenService::Observer:

- virtual void OnRefreshTokenAvailable(const std::string& account_id) override;

+ void OnRefreshTokenAvailable(const std::string& account_id) override;

// Disables network requests for testing to avoid messing up with irrelevant

// tests.