Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: components/signin/core/browser/about_signin_internals.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/about_signin_internals.h
diff --git a/components/signin/core/browser/about_signin_internals.h b/components/signin/core/browser/about_signin_internals.h
index 94fca773af89572ab18b7a1250859e2e9b8e6f3a..c7e264c2b80837e7eb25d882c5662cd0cf4c2565 100644
--- a/components/signin/core/browser/about_signin_internals.h
+++ b/components/signin/core/browser/about_signin_internals.h
@@ -48,7 +48,7 @@ class AboutSigninInternals
AboutSigninInternals(ProfileOAuth2TokenService* token_service,
SigninManagerBase* signin_manager);
- virtual ~AboutSigninInternals();
+ ~AboutSigninInternals() override;
// Each instance of SigninInternalsUI adds itself as an observer to be
// notified of all updates that AboutSigninInternals receives.
@@ -59,18 +59,18 @@ class AboutSigninInternals
void RefreshSigninPrefs();
// SigninManager::SigninDiagnosticsObserver implementation.
- virtual void NotifySigninValueChanged(
+ void NotifySigninValueChanged(
const signin_internals_util::UntimedSigninStatusField& field,
const std::string& value) override;
- virtual void NotifySigninValueChanged(
+ void NotifySigninValueChanged(
const signin_internals_util::TimedSigninStatusField& field,
const std::string& value) override;
void Initialize(SigninClient* client);
// KeyedService implementation.
- virtual void Shutdown() override;
+ void Shutdown() override;
// Returns a dictionary of values in signin_status_ for use in
// about:signin-internals. The values are formatted as shown -
@@ -93,19 +93,17 @@ class AboutSigninInternals
void GetCookieAccountsAsync();
// OAuth2TokenService::DiagnosticsObserver implementations.
- virtual void OnAccessTokenRequested(
+ void OnAccessTokenRequested(
const std::string& account_id,
const std::string& consumer_id,
const OAuth2TokenService::ScopeSet& scopes) override;
- virtual void OnFetchAccessTokenComplete(
- const std::string& account_id,
- const std::string& consumer_id,
- const OAuth2TokenService::ScopeSet& scopes,
- GoogleServiceAuthError error,
- base::Time expiration_time) override;
- virtual void OnTokenRemoved(const std::string& account_id,
- const OAuth2TokenService::ScopeSet& scopes)
- override;
+ void OnFetchAccessTokenComplete(const std::string& account_id,
+ const std::string& consumer_id,
+ const OAuth2TokenService::ScopeSet& scopes,
+ GoogleServiceAuthError error,
+ base::Time expiration_time) override;
+ void OnTokenRemoved(const std::string& account_id,
+ const OAuth2TokenService::ScopeSet& scopes) override;
void OnRefreshTokenReceived(std::string status);
void OnAuthenticationResultReceived(std::string status);
@@ -174,9 +172,8 @@ class AboutSigninInternals
// Overriden from GaiaAuthConsumer.
- virtual void OnListAccountsSuccess(const std::string& data) override;
- virtual void OnListAccountsFailure(const GoogleServiceAuthError& error)
- override;
+ void OnListAccountsSuccess(const std::string& data) override;
+ void OnListAccountsFailure(const GoogleServiceAuthError& error) override;
// Callback for ListAccounts. Once the email addresses are fetched from GAIA,
// they are pushed to the signin_internals_ui.
« no previous file with comments | « components/search_provider_logos/logo_tracker_unittest.cc ('k') | components/signin/core/browser/account_reconcilor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698