components/renderer_context_menu/render_view_context_menu_base.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/renderer_context_menu/context_menu_delegate.cc ('k') | components/search_engines/default_search_policy_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/render_view_context_menu_base.h

diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h

index f3a822afea3cf5fe68f80531e51a6674c09fe86e..45b3fc54b37044a0c9c6260dc88d6f3ebcff40e5 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.h

+++ b/components/renderer_context_menu/render_view_context_menu_base.h

@@ -67,7 +67,7 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

RenderViewContextMenuBase(content::RenderFrameHost* render_frame_host,

const content::ContextMenuParams& params);

- virtual ~RenderViewContextMenuBase();

+ ~RenderViewContextMenuBase() override;

// Initializes the context menu.

void Init();

@@ -84,27 +84,25 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

bool IsCommandIdKnown(int command_id, bool* enabled) const;

// SimpleMenuModel::Delegate implementation.

- virtual bool IsCommandIdChecked(int command_id) const override;

- virtual void ExecuteCommand(int command_id, int event_flags) override;

- virtual void MenuWillShow(ui::SimpleMenuModel* source) override;

- virtual void MenuClosed(ui::SimpleMenuModel* source) override;

+ bool IsCommandIdChecked(int command_id) const override;

+ void ExecuteCommand(int command_id, int event_flags) override;

+ void MenuWillShow(ui::SimpleMenuModel* source) override;

+ void MenuClosed(ui::SimpleMenuModel* source) override;

// RenderViewContextMenuProxy implementation.

- virtual void AddMenuItem(int command_id,

- const base::string16& title) override;

- virtual void AddCheckItem(int command_id,

- const base::string16& title) override;

- virtual void AddSeparator() override;

- virtual void AddSubMenu(int command_id,

- const base::string16& label,

- ui::MenuModel* model) override;

- virtual void UpdateMenuItem(int command_id,

- bool enabled,

- bool hidden,

- const base::string16& title) override;

- virtual content::RenderViewHost* GetRenderViewHost() const override;

- virtual content::WebContents* GetWebContents() const override;

- virtual content::BrowserContext* GetBrowserContext() const override;

+ void AddMenuItem(int command_id, const base::string16& title) override;

+ void AddCheckItem(int command_id, const base::string16& title) override;

+ void AddSeparator() override;

+ void AddSubMenu(int command_id,

+ const base::string16& label,

+ ui::MenuModel* model) override;

+ void UpdateMenuItem(int command_id,

+ bool enabled,

+ bool hidden,

+ const base::string16& title) override;

+ content::RenderViewHost* GetRenderViewHost() const override;

+ content::WebContents* GetWebContents() const override;

+ content::BrowserContext* GetBrowserContext() const override;

protected:

friend class RenderViewContextMenuTest;