components/policy/core/common/configuration_policy_provider.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/configuration_policy_provider.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/config_dir_policy_loader_unittest.cc ('k') | components/policy/core/common/forwarding_policy_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/configuration_policy_provider.h

diff --git a/components/policy/core/common/configuration_policy_provider.h b/components/policy/core/common/configuration_policy_provider.h

index b01be0ac5974a31bcec307eb757c5e92eb27513c..73a5d1d80f6271b1f08689b1546b1efb00a3b279 100644

--- a/components/policy/core/common/configuration_policy_provider.h

+++ b/components/policy/core/common/configuration_policy_provider.h

@@ -34,7 +34,7 @@ class POLICY_EXPORT ConfigurationPolicyProvider

// and it's not guaranteed that the message loops will still be running when

// this is invoked. Override Shutdown() instead for cleanup code that needs

// to post to the FILE thread, for example.

- virtual ~ConfigurationPolicyProvider();

+ ~ConfigurationPolicyProvider() override;

// Invoked as soon as the main message loops are spinning. Policy providers

// are created early during startup to provide the initial policies; the

@@ -71,8 +71,8 @@ class POLICY_EXPORT ConfigurationPolicyProvider

virtual void RemoveObserver(Observer* observer);

// SchemaRegistry::Observer:

- virtual void OnSchemaRegistryUpdated(bool has_new_schemas) override;

- virtual void OnSchemaRegistryReady() override;

+ void OnSchemaRegistryUpdated(bool has_new_schemas) override;

+ void OnSchemaRegistryReady() override;

protected:

// Subclasses must invoke this to update the policies currently served by