components/policy/core/common/cloud/component_cloud_policy_service.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_service.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/component_cloud_policy_service.h ('k') | components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/component_cloud_policy_service.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_service.cc b/components/policy/core/common/cloud/component_cloud_policy_service.cc

index 7cb6335a45326e4c2f97dc92091820dee0377638..0ba5db11f3d5736ce033cf6d8615c8abe48624f6 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_service.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_service.cc

@@ -62,7 +62,7 @@ class ComponentCloudPolicyService::Backend

scoped_ptr<ResourceCache> cache,

scoped_ptr<ExternalPolicyDataFetcher> external_policy_data_fetcher);

- virtual ~Backend();

+ ~Backend() override;

// |username| and |dm_token| will be used to validate the cached policies.

void SetCredentials(const std::string& username, const std::string& dm_token);

@@ -75,7 +75,7 @@ class ComponentCloudPolicyService::Backend

void UpdateExternalPolicy(scoped_ptr<em::PolicyFetchResponse> response);

// ComponentCloudPolicyStore::Delegate implementation:

- virtual void OnComponentCloudPolicyStoreUpdated() override;

+ void OnComponentCloudPolicyStoreUpdated() override;

// Passes the current SchemaMap so that the disk cache can purge components

// that aren't being tracked anymore.