components/policy/core/common/cloud/cloud_policy_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_core_unittest.cc ('k') | components/policy/core/common/cloud/cloud_policy_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_manager.h

diff --git a/components/policy/core/common/cloud/cloud_policy_manager.h b/components/policy/core/common/cloud/cloud_policy_manager.h

index f6559166eda5667fb55122a13c2aa1be82416f59..95efe6a34d38a7aa20dd4a86a815d30e5df169a0 100644

--- a/components/policy/core/common/cloud/cloud_policy_manager.h

+++ b/components/policy/core/common/cloud/cloud_policy_manager.h

@@ -55,22 +55,22 @@ class POLICY_EXPORT CloudPolicyManager

const scoped_refptr<base::SequencedTaskRunner>& task_runner,

const scoped_refptr<base::SequencedTaskRunner>& file_task_runner,

const scoped_refptr<base::SequencedTaskRunner>& io_task_runner);

- virtual ~CloudPolicyManager();

+ ~CloudPolicyManager() override;

CloudPolicyCore* core() { return &core_; }

const CloudPolicyCore* core() const { return &core_; }

// ConfigurationPolicyProvider:

- virtual void Shutdown() override;

- virtual bool IsInitializationComplete(PolicyDomain domain) const override;

- virtual void RefreshPolicies() override;

+ void Shutdown() override;

+ bool IsInitializationComplete(PolicyDomain domain) const override;

+ void RefreshPolicies() override;

// CloudPolicyStore::Observer:

- virtual void OnStoreLoaded(CloudPolicyStore* cloud_policy_store) override;

- virtual void OnStoreError(CloudPolicyStore* cloud_policy_store) override;

+ void OnStoreLoaded(CloudPolicyStore* cloud_policy_store) override;

+ void OnStoreError(CloudPolicyStore* cloud_policy_store) override;

// ComponentCloudPolicyService::Delegate:

- virtual void OnComponentCloudPolicyUpdated() override;

+ void OnComponentCloudPolicyUpdated() override;

protected:

// Check whether fully initialized and if so, publish policy by calling