components/policy/core/browser/policy_error_map.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/policy_error_map.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/browser/configuration_policy_pref_store.h ('k') | components/policy/core/browser/url_blacklist_policy_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/policy_error_map.cc

diff --git a/components/policy/core/browser/policy_error_map.cc b/components/policy/core/browser/policy_error_map.cc

index 4d9c59d424f46cfc1fd1a877be9e8cda2ad4623b..60ec87515eb8e701eeb088ca5a341ad678562a2e 100644

--- a/components/policy/core/browser/policy_error_map.cc

+++ b/components/policy/core/browser/policy_error_map.cc

@@ -41,9 +41,9 @@ class SimplePendingError : public PolicyErrorMap::PendingError {

: PendingError(policy_name),

message_id_(message_id),

replacement_(replacement) {}

- virtual ~SimplePendingError() {}

+ ~SimplePendingError() override {}

- virtual base::string16 GetMessage() const override {

+ base::string16 GetMessage() const override {

if (message_id_ >= 0) {

if (replacement_.empty())

return l10n_util::GetStringUTF16(message_id_);

@@ -68,9 +68,9 @@ class DictSubkeyPendingError : public SimplePendingError {

const std::string& replacement)

: SimplePendingError(policy_name, message_id, replacement),

subkey_(subkey) {}

- virtual ~DictSubkeyPendingError() {}

+ ~DictSubkeyPendingError() override {}

- virtual base::string16 GetMessage() const override {

+ base::string16 GetMessage() const override {

return l10n_util::GetStringFUTF16(IDS_POLICY_SUBKEY_ERROR,

base::ASCIIToUTF16(subkey_),

SimplePendingError::GetMessage());

@@ -90,9 +90,9 @@ class ListItemPendingError : public SimplePendingError {

const std::string& replacement)

: SimplePendingError(policy_name, message_id, replacement),

index_(index) {}

- virtual ~ListItemPendingError() {}

+ ~ListItemPendingError() override {}

- virtual base::string16 GetMessage() const override {

+ base::string16 GetMessage() const override {

return l10n_util::GetStringFUTF16(IDS_POLICY_LIST_ENTRY_ERROR,

base::IntToString16(index_),

SimplePendingError::GetMessage());

@@ -111,9 +111,9 @@ class SchemaValidatingPendingError : public SimplePendingError {

const std::string& replacement)

: SimplePendingError(policy_name, -1, replacement),

error_path_(error_path) {};

- virtual ~SchemaValidatingPendingError() {}

+ ~SchemaValidatingPendingError() override {}

- virtual base::string16 GetMessage() const override {

+ base::string16 GetMessage() const override {

return l10n_util::GetStringFUTF16(IDS_POLICY_SCHEMA_VALIDATION_ERROR,

base::ASCIIToUTF16(error_path_),

SimplePendingError::GetMessage());