components/policy/core/browser/configuration_policy_handler_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_handler_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/browser/configuration_policy_handler.h ('k') | components/policy/core/browser/configuration_policy_pref_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/configuration_policy_handler_unittest.cc

diff --git a/components/policy/core/browser/configuration_policy_handler_unittest.cc b/components/policy/core/browser/configuration_policy_handler_unittest.cc

index 83861abefb7d418cced7c5a50905a9abe907f20c..832dd71c7da8da18e09beb92e0975226becb4700 100644

--- a/components/policy/core/browser/configuration_policy_handler_unittest.cc

+++ b/components/policy/core/browser/configuration_policy_handler_unittest.cc

@@ -34,11 +34,9 @@ class TestSchemaValidatingPolicyHandler : public SchemaValidatingPolicyHandler {

TestSchemaValidatingPolicyHandler(const Schema& schema,

SchemaOnErrorStrategy strategy)

: SchemaValidatingPolicyHandler("PolicyForTesting", schema, strategy) {}

- virtual ~TestSchemaValidatingPolicyHandler() {}

+ ~TestSchemaValidatingPolicyHandler() override {}

- virtual void ApplyPolicySettings(const policy::PolicyMap&,

- PrefValueMap*) override {

- }

+ void ApplyPolicySettings(const policy::PolicyMap&, PrefValueMap*) override {}

bool CheckAndGetValueForTest(const PolicyMap& policies,

scoped_ptr<base::Value>* value) {