Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: components/password_manager/core/browser/test_password_store.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/test_password_store.h
diff --git a/components/password_manager/core/browser/test_password_store.h b/components/password_manager/core/browser/test_password_store.h
index 7c44b0ba27cc630dcdd580f58d893838f8bd97a4..f759d488743d34139fa8193ed7eaf116584f6d41 100644
--- a/components/password_manager/core/browser/test_password_store.h
+++ b/components/password_manager/core/browser/test_password_store.h
@@ -38,40 +38,39 @@ class TestPasswordStore : public PasswordStore {
bool IsEmpty() const;
protected:
- virtual ~TestPasswordStore();
+ ~TestPasswordStore() override;
// Helper function to determine if forms are considered equivalent.
bool FormsAreEquivalent(const autofill::PasswordForm& lhs,
const autofill::PasswordForm& rhs);
// PasswordStore interface
- virtual PasswordStoreChangeList AddLoginImpl(
+ PasswordStoreChangeList AddLoginImpl(
const autofill::PasswordForm& form) override;
- virtual PasswordStoreChangeList UpdateLoginImpl(
+ PasswordStoreChangeList UpdateLoginImpl(
const autofill::PasswordForm& form) override;
- virtual PasswordStoreChangeList RemoveLoginImpl(
+ PasswordStoreChangeList RemoveLoginImpl(
const autofill::PasswordForm& form) override;
- virtual void GetLoginsImpl(
- const autofill::PasswordForm& form,
- PasswordStore::AuthorizationPromptPolicy prompt_policy,
- const ConsumerCallbackRunner& runner) override;
- virtual void WrapModificationTask(ModificationTask task) override;
+ void GetLoginsImpl(const autofill::PasswordForm& form,
+ PasswordStore::AuthorizationPromptPolicy prompt_policy,
+ const ConsumerCallbackRunner& runner) override;
+ void WrapModificationTask(ModificationTask task) override;
// Unused portions of PasswordStore interface
- virtual void ReportMetricsImpl(const std::string& sync_username) override {}
- virtual PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
+ void ReportMetricsImpl(const std::string& sync_username) override {}
+ PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
base::Time begin,
base::Time end) override;
- virtual PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
+ PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
base::Time delete_begin,
base::Time delete_end) override;
- virtual void GetAutofillableLoginsImpl(
+ void GetAutofillableLoginsImpl(
PasswordStore::GetLoginsRequest* request) override {}
- virtual void GetBlacklistLoginsImpl(
+ void GetBlacklistLoginsImpl(
PasswordStore::GetLoginsRequest* request) override {}
- virtual bool FillAutofillableLogins(
+ bool FillAutofillableLogins(
std::vector<autofill::PasswordForm*>* forms) override;
- virtual bool FillBlacklistLogins(
+ bool FillBlacklistLogins(
std::vector<autofill::PasswordForm*>* forms) override;
private:

Powered by Google App Engine
This is Rietveld 408576698