components/password_manager/core/browser/password_form_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager_unittest.cc ('k') | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index fce6f9c32add916ed7afdec5447326aaaec752f3..67ac2ea4ccb6f45820eaa36e2d32e642bab7e376 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -39,7 +39,7 @@ class PasswordFormManager : public PasswordStoreConsumer {

PasswordManagerDriver* driver,

const autofill::PasswordForm& observed_form,

bool ssl_valid);

- virtual ~PasswordFormManager();

+ ~PasswordFormManager() override;

// Flags describing the result of comparing two forms as performed by

// DoesMatch. Individual flags are only relevant for HTML forms, but

@@ -113,7 +113,7 @@ class PasswordFormManager : public PasswordStoreConsumer {

// Takes ownership of the elements in |result|.

void OnRequestDone(const std::vector<autofill::PasswordForm*>& result);

- virtual void OnGetPasswordStoreResults(

+ void OnGetPasswordStoreResults(

const std::vector<autofill::PasswordForm*>& results) override;

// A user opted to 'never remember' passwords for this form.