components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_credential_manager_dispatcher.h ('k') | components/password_manager/content/browser/content_password_manager_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

index 3cff96672b54f4c50268faab55064e9b0838d42e..2b1665695b92beb27e167ad71a87d4b0f1a66474 100644

--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

@@ -33,17 +33,17 @@ class TestPasswordManagerClient

public:

TestPasswordManagerClient(password_manager::PasswordStore* store)

: did_prompt_user_to_save_(false), store_(store) {}

- virtual ~TestPasswordManagerClient() {}

+ ~TestPasswordManagerClient() override {}

- virtual password_manager::PasswordStore* GetPasswordStore() override {

+ password_manager::PasswordStore* GetPasswordStore() override {

return store_;

}

- virtual password_manager::PasswordManagerDriver* GetDriver() override {

+ password_manager::PasswordManagerDriver* GetDriver() override {

return &driver_;

}

- virtual bool PromptUserToSavePassword(

+ bool PromptUserToSavePassword(

scoped_ptr<password_manager::PasswordFormManager> manager) override {

did_prompt_user_to_save_ = true;

manager_.reset(manager.release());