Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: components/nacl/loader/nacl_validation_query_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/loader/nacl_trusted_listener.h ('k') | components/nacl/renderer/manifest_service_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/loader/nacl_validation_query_unittest.cc
diff --git a/components/nacl/loader/nacl_validation_query_unittest.cc b/components/nacl/loader/nacl_validation_query_unittest.cc
index 288f1c44022371811515d985ca88becaf9d60be9..6c2dfa84c5bd1b8b99d7186759d9c75e8c85ed24 100644
--- a/components/nacl/loader/nacl_validation_query_unittest.cc
+++ b/components/nacl/loader/nacl_validation_query_unittest.cc
@@ -39,7 +39,7 @@ class MockValidationDB : public NaClValidationDB {
status_(true) {
}
- virtual bool QueryKnownToValidate(const std::string& signature) override {
+ bool QueryKnownToValidate(const std::string& signature) override {
// The typecast is needed to work around gtest trying to take the address
// of a constant.
EXPECT_EQ((int) NaClValidationQuery::kDigestLength,
@@ -52,7 +52,7 @@ class MockValidationDB : public NaClValidationDB {
return status_;
}
- virtual void SetKnownToValidate(const std::string& signature) override {
+ void SetKnownToValidate(const std::string& signature) override {
// The typecast is needed to work around gtest trying to take the address
// of a constant.
ASSERT_EQ((int) NaClValidationQuery::kDigestLength,
@@ -67,8 +67,9 @@ class MockValidationDB : public NaClValidationDB {
NaClValidationQuery::kDigestLength));
}
- virtual bool ResolveFileToken(struct NaClFileToken* file_token, int32* fd,
- std::string* path) override {
+ bool ResolveFileToken(struct NaClFileToken* file_token,
+ int32* fd,
+ std::string* path) override {
*fd = -1;
*path = "";
return false;
« no previous file with comments | « components/nacl/loader/nacl_trusted_listener.h ('k') | components/nacl/renderer/manifest_service_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698