components/nacl/loader/nacl_ipc_adapter_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_ipc_adapter_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/loader/nacl_ipc_adapter_unittest.cc

diff --git a/components/nacl/loader/nacl_ipc_adapter_unittest.cc b/components/nacl/loader/nacl_ipc_adapter_unittest.cc

index fc812a6b6f72822cc5dcfbb58235562bae951c45..99f4638a485545edc9008a8bd527f3d94f9862c1 100644

--- a/components/nacl/loader/nacl_ipc_adapter_unittest.cc

+++ b/components/nacl/loader/nacl_ipc_adapter_unittest.cc

@@ -279,7 +279,7 @@ TEST_F(NaClIPCAdapterTest, ReadWithChannelError) {

explicit MyThread(NaClIPCAdapter* adapter)

: SimpleThread("NaClIPCAdapterThread"),

adapter_(adapter) {}

- virtual void Run() override {

+ void Run() override {

base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(1));

adapter_->OnChannelError();

}

« no previous file with comments | « components/nacl/loader/nacl_ipc_adapter.h ('k') | components/nacl/loader/nacl_listener.h » ('j') | no next file with comments »