Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: components/metrics/test_metrics_service_client.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/test_metrics_service_client.h
diff --git a/components/metrics/test_metrics_service_client.h b/components/metrics/test_metrics_service_client.h
index 8565ca93b431597c0a6e7bcfdc819875ee48b1bb..c46ac4e9b052deba9d250bb44cd9c8c0591d6f80 100644
--- a/components/metrics/test_metrics_service_client.h
+++ b/components/metrics/test_metrics_service_client.h
@@ -18,22 +18,20 @@ class TestMetricsServiceClient : public MetricsServiceClient {
static const char kBrandForTesting[];
TestMetricsServiceClient();
- virtual ~TestMetricsServiceClient();
+ ~TestMetricsServiceClient() override;
// MetricsServiceClient:
- virtual void SetMetricsClientId(const std::string& client_id) override;
- virtual bool IsOffTheRecordSessionActive() override;
- virtual int32_t GetProduct() override;
- virtual std::string GetApplicationLocale() override;
- virtual bool GetBrand(std::string* brand_code) override;
- virtual SystemProfileProto::Channel GetChannel() override;
- virtual std::string GetVersionString() override;
- virtual void OnLogUploadComplete() override;
- virtual void StartGatheringMetrics(
- const base::Closure& done_callback) override;
- virtual void CollectFinalMetrics(const base::Closure& done_callback)
- override;
- virtual scoped_ptr<MetricsLogUploader> CreateUploader(
+ void SetMetricsClientId(const std::string& client_id) override;
+ bool IsOffTheRecordSessionActive() override;
+ int32_t GetProduct() override;
+ std::string GetApplicationLocale() override;
+ bool GetBrand(std::string* brand_code) override;
+ SystemProfileProto::Channel GetChannel() override;
+ std::string GetVersionString() override;
+ void OnLogUploadComplete() override;
+ void StartGatheringMetrics(const base::Closure& done_callback) override;
+ void CollectFinalMetrics(const base::Closure& done_callback) override;
+ scoped_ptr<MetricsLogUploader> CreateUploader(
const std::string& server_url,
const std::string& mime_type,
const base::Callback<void(int)>& on_upload_complete) override;
« no previous file with comments | « components/metrics/profiler/tracking_synchronizer.h ('k') | components/nacl/browser/nacl_file_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698