Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/invalidation/push_client_channel.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/invalidation/push_client_channel.h
diff --git a/components/invalidation/push_client_channel.h b/components/invalidation/push_client_channel.h
index 7e3f002a12455086bbe82223613ab267d4597240..51b0954702174ce41004e02b944fecfa656c3dcf 100644
--- a/components/invalidation/push_client_channel.h
+++ b/components/invalidation/push_client_channel.h
@@ -30,26 +30,26 @@ class INVALIDATION_EXPORT_PRIVATE PushClientChannel
// is destroyed.
explicit PushClientChannel(scoped_ptr<notifier::PushClient> push_client);
- virtual ~PushClientChannel();
+ ~PushClientChannel() override;
// invalidation::NetworkChannel implementation.
- virtual void SendMessage(const std::string& message) override;
- virtual void RequestDetailedStatus(
+ void SendMessage(const std::string& message) override;
+ void RequestDetailedStatus(
base::Callback<void(const base::DictionaryValue&)> callback) override;
// SyncNetworkChannel implementation.
// If not connected, connects with the given credentials. If
// already connected, the next connection attempt will use the given
// credentials.
- virtual void UpdateCredentials(const std::string& email,
- const std::string& token) override;
- virtual int GetInvalidationClientType() override;
+ void UpdateCredentials(const std::string& email,
+ const std::string& token) override;
+ int GetInvalidationClientType() override;
// notifier::PushClient::Observer implementation.
- virtual void OnNotificationsEnabled() override;
- virtual void OnNotificationsDisabled(
+ void OnNotificationsEnabled() override;
+ void OnNotificationsDisabled(
notifier::NotificationsDisabledReason reason) override;
- virtual void OnIncomingNotification(
+ void OnIncomingNotification(
const notifier::Notification& notification) override;
const std::string& GetServiceContextForTest() const;
« no previous file with comments | « components/invalidation/profile_invalidation_provider.h ('k') | components/invalidation/push_client_channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698