components/history/core/browser/in_memory_database.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/in_memory_database.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/google/core/browser/google_url_tracker_unittest.cc ('k') | components/history/core/browser/url_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/in_memory_database.h

diff --git a/components/history/core/browser/in_memory_database.h b/components/history/core/browser/in_memory_database.h

index 6a010dec5e198e194b09d99d31ec4a0bd0717df3..9730f1ee0106d40085344cf2c752ba0cb2b2048e 100644

--- a/components/history/core/browser/in_memory_database.h

+++ b/components/history/core/browser/in_memory_database.h

@@ -21,7 +21,7 @@ namespace history {

class InMemoryDatabase : public URLDatabase {

public:

InMemoryDatabase();

- virtual ~InMemoryDatabase();

+ ~InMemoryDatabase() override;

// Creates an empty in-memory database.

bool InitFromScratch();

@@ -34,7 +34,7 @@ class InMemoryDatabase : public URLDatabase {

protected:

// Implemented for URLDatabase.

- virtual sql::Connection& GetDB() override;

+ sql::Connection& GetDB() override;

private:

// Initializes the database connection, this is the shared code between