components/google/core/browser/google_url_tracker_infobar_delegate.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/google/core/browser/google_url_tracker_infobar_delegate.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/google/core/browser/google_url_tracker.h ('k') | components/google/core/browser/google_url_tracker_map_entry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/google/core/browser/google_url_tracker_infobar_delegate.h

diff --git a/components/google/core/browser/google_url_tracker_infobar_delegate.h b/components/google/core/browser/google_url_tracker_infobar_delegate.h

index 601b4b35931d73b44a27665c8615ffb44d7dc139..dac9874c0e23ed71b2cf884ebe9308d1f6022d2f 100644

--- a/components/google/core/browser/google_url_tracker_infobar_delegate.h

+++ b/components/google/core/browser/google_url_tracker_infobar_delegate.h

@@ -27,8 +27,8 @@ class GoogleURLTrackerInfoBarDelegate : public ConfirmInfoBarDelegate {

const GURL& search_url);

// ConfirmInfoBarDelegate:

- virtual bool Accept() override;

- virtual bool Cancel() override;

+ bool Accept() override;

+ bool Cancel() override;

GoogleURLTrackerNavigationHelper* navigation_helper() {

return navigation_helper_weak_ptr_;

@@ -54,16 +54,15 @@ class GoogleURLTrackerInfoBarDelegate : public ConfirmInfoBarDelegate {

GoogleURLTrackerInfoBarDelegate(

GoogleURLTracker* google_url_tracker,

const GURL& search_url);

- virtual ~GoogleURLTrackerInfoBarDelegate();

+ ~GoogleURLTrackerInfoBarDelegate() override;

private:

// ConfirmInfoBarDelegate:

- virtual base::string16 GetMessageText() const override;

- virtual base::string16 GetButtonLabel(InfoBarButton button) const override;

- virtual base::string16 GetLinkText() const override;

- virtual bool LinkClicked(WindowOpenDisposition disposition) override;

- virtual bool ShouldExpireInternal(

- const NavigationDetails& details) const override;

+ base::string16 GetMessageText() const override;

+ base::string16 GetButtonLabel(InfoBarButton button) const override;

+ base::string16 GetLinkText() const override;

+ bool LinkClicked(WindowOpenDisposition disposition) override;

+ bool ShouldExpireInternal(const NavigationDetails& details) const override;

GoogleURLTracker* google_url_tracker_;

scoped_ptr<GoogleURLTrackerNavigationHelper> navigation_helper_;