Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver_desktop.cc
diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc
index 35e2a811d317d8508f6d2989db9bbc828f887125..fc0c36af2ff0a2c45e781821c92c0f473641734e 100644
--- a/components/gcm_driver/gcm_driver_desktop.cc
+++ b/components/gcm_driver/gcm_driver_desktop.cc
@@ -35,28 +35,26 @@ class GCMDriverDesktop::IOWorker : public GCMClient::Delegate {
// Overridden from GCMClient::Delegate:
// Called on IO thread.
- virtual void OnRegisterFinished(const std::string& app_id,
- const std::string& registration_id,
- GCMClient::Result result) override;
- virtual void OnUnregisterFinished(const std::string& app_id,
- GCMClient::Result result) override;
- virtual void OnSendFinished(const std::string& app_id,
- const std::string& message_id,
- GCMClient::Result result) override;
- virtual void OnMessageReceived(
- const std::string& app_id,
- const GCMClient::IncomingMessage& message) override;
- virtual void OnMessagesDeleted(const std::string& app_id) override;
- virtual void OnMessageSendError(
+ void OnRegisterFinished(const std::string& app_id,
+ const std::string& registration_id,
+ GCMClient::Result result) override;
+ void OnUnregisterFinished(const std::string& app_id,
+ GCMClient::Result result) override;
+ void OnSendFinished(const std::string& app_id,
+ const std::string& message_id,
+ GCMClient::Result result) override;
+ void OnMessageReceived(const std::string& app_id,
+ const GCMClient::IncomingMessage& message) override;
+ void OnMessagesDeleted(const std::string& app_id) override;
+ void OnMessageSendError(
const std::string& app_id,
const GCMClient::SendErrorDetails& send_error_details) override;
- virtual void OnSendAcknowledged(const std::string& app_id,
- const std::string& message_id) override;
- virtual void OnGCMReady(
- const std::vector<AccountMapping>& account_mappings) override;
- virtual void OnActivityRecorded() override;
- virtual void OnConnected(const net::IPEndPoint& ip_endpoint) override;
- virtual void OnDisconnected() override;
+ void OnSendAcknowledged(const std::string& app_id,
+ const std::string& message_id) override;
+ void OnGCMReady(const std::vector<AccountMapping>& account_mappings) override;
+ void OnActivityRecorded() override;
+ void OnConnected(const net::IPEndPoint& ip_endpoint) override;
+ void OnDisconnected() override;
// Called on IO thread.
void Initialize(
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698