Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: components/gcm_driver/gcm_client_impl.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_client_impl.h
diff --git a/components/gcm_driver/gcm_client_impl.h b/components/gcm_driver/gcm_client_impl.h
index 6abe14966ed72e03ecb1e862d8f26e072fdda500..a20cb12c0794dfb78b98832da4281658195bf27f 100644
--- a/components/gcm_driver/gcm_client_impl.h
+++ b/components/gcm_driver/gcm_client_impl.h
@@ -80,10 +80,10 @@ class GCMClientImpl
public ConnectionFactory::ConnectionListener {
public:
explicit GCMClientImpl(scoped_ptr<GCMInternalsBuilder> internals_builder);
- virtual ~GCMClientImpl();
+ ~GCMClientImpl() override;
// GCMClient implementation.
- virtual void Initialize(
+ void Initialize(
const ChromeBuildInfo& chrome_build_info,
const base::FilePath& store_path,
const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner,
@@ -91,31 +91,30 @@ class GCMClientImpl
url_request_context_getter,
scoped_ptr<Encryptor> encryptor,
GCMClient::Delegate* delegate) override;
- virtual void Start() override;
- virtual void Stop() override;
- virtual void CheckOut() override;
- virtual void Register(const std::string& app_id,
- const std::vector<std::string>& sender_ids) override;
- virtual void Unregister(const std::string& app_id) override;
- virtual void Send(const std::string& app_id,
- const std::string& receiver_id,
- const OutgoingMessage& message) override;
- virtual void SetRecording(bool recording) override;
- virtual void ClearActivityLogs() override;
- virtual GCMStatistics GetStatistics() const override;
- virtual void SetAccountTokens(
+ void Start() override;
+ void Stop() override;
+ void CheckOut() override;
+ void Register(const std::string& app_id,
+ const std::vector<std::string>& sender_ids) override;
+ void Unregister(const std::string& app_id) override;
+ void Send(const std::string& app_id,
+ const std::string& receiver_id,
+ const OutgoingMessage& message) override;
+ void SetRecording(bool recording) override;
+ void ClearActivityLogs() override;
+ GCMStatistics GetStatistics() const override;
+ void SetAccountTokens(
const std::vector<AccountTokenInfo>& account_tokens) override;
- virtual void UpdateAccountMapping(
- const AccountMapping& account_mapping) override;
- virtual void RemoveAccountMapping(const std::string& account_id) override;
+ void UpdateAccountMapping(const AccountMapping& account_mapping) override;
+ void RemoveAccountMapping(const std::string& account_id) override;
// GCMStatsRecorder::Delegate implemenation.
- virtual void OnActivityRecorded() override;
+ void OnActivityRecorded() override;
// ConnectionFactory::ConnectionListener implementation.
- virtual void OnConnected(const GURL& current_server,
- const net::IPEndPoint& ip_endpoint) override;
- virtual void OnDisconnected() override;
+ void OnConnected(const GURL& current_server,
+ const net::IPEndPoint& ip_endpoint) override;
+ void OnDisconnected() override;
private:
// State representation of the GCMClient.
« no previous file with comments | « components/gcm_driver/gcm_channel_status_request.h ('k') | components/gcm_driver/gcm_client_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698