Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: components/gcm_driver/gcm_activity.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_activity.h
diff --git a/components/gcm_driver/gcm_activity.h b/components/gcm_driver/gcm_activity.h
index 0d3da0c5fd94fedf2931049bb0136f740cc5da8d..2209cb0b414055010d5ca6df2a5feda82caea5d7 100644
--- a/components/gcm_driver/gcm_activity.h
+++ b/components/gcm_driver/gcm_activity.h
@@ -25,19 +25,19 @@ struct Activity {
// Contains relevant data of a connection activity.
struct ConnectionActivity : Activity {
ConnectionActivity();
- virtual ~ConnectionActivity();
+ ~ConnectionActivity() override;
};
// Contains relevant data of a check-in activity.
struct CheckinActivity : Activity {
CheckinActivity();
- virtual ~CheckinActivity();
+ ~CheckinActivity() override;
};
// Contains relevant data of a registration/unregistration step.
struct RegistrationActivity : Activity {
RegistrationActivity();
- virtual ~RegistrationActivity();
+ ~RegistrationActivity() override;
std::string app_id;
std::string sender_ids; // Comma separated sender ids.
@@ -46,7 +46,7 @@ struct RegistrationActivity : Activity {
// Contains relevant data of a message receiving event.
struct ReceivingActivity : Activity {
ReceivingActivity();
- virtual ~ReceivingActivity();
+ ~ReceivingActivity() override;
std::string app_id;
std::string from;
@@ -56,7 +56,7 @@ struct ReceivingActivity : Activity {
// Contains relevant data of a send-message step.
struct SendingActivity : Activity {
SendingActivity();
- virtual ~SendingActivity();
+ ~SendingActivity() override;
std::string app_id;
std::string receiver_id;
« no previous file with comments | « components/gcm_driver/gcm_account_mapper_unittest.cc ('k') | components/gcm_driver/gcm_channel_status_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698