components/favicon/core/browser/favicon_client.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/browser/favicon_client.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/error_page/renderer/net_error_helper_core_unittest.cc ('k') | components/favicon_base/select_favicon_frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/favicon/core/browser/favicon_client.h

diff --git a/components/favicon/core/browser/favicon_client.h b/components/favicon/core/browser/favicon_client.h

index f33d54a028d02e44a3c120a8c4f1bb76c09f18ca..bad4437d1b0c5e7ff4c9009ec74dae53883080ef 100644

--- a/components/favicon/core/browser/favicon_client.h

+++ b/components/favicon/core/browser/favicon_client.h

@@ -14,7 +14,7 @@ class GURL;

// e.g. Chrome.

class FaviconClient : public KeyedService {

public:

- virtual ~FaviconClient() {};

+ ~FaviconClient() override{};

virtual FaviconService* GetFaviconService() = 0;