Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_model.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/enhanced_bookmark_model.h
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_model.h b/components/enhanced_bookmarks/enhanced_bookmark_model.h
index d46e7d9f600a43d5fdb09cde8da958bfe730c449..d708d8d82a3ef0ef96d54e8267dad5949416282c 100644
--- a/components/enhanced_bookmarks/enhanced_bookmark_model.h
+++ b/components/enhanced_bookmarks/enhanced_bookmark_model.h
@@ -38,9 +38,9 @@ class EnhancedBookmarkModel : public KeyedService,
public:
EnhancedBookmarkModel(BookmarkModel* bookmark_model,
const std::string& version);
- virtual ~EnhancedBookmarkModel();
+ ~EnhancedBookmarkModel() override;
- virtual void Shutdown() override;
+ void Shutdown() override;
void AddObserver(EnhancedBookmarkModelObserver* observer);
void RemoveObserver(EnhancedBookmarkModelObserver* observer);
@@ -139,24 +139,22 @@ class EnhancedBookmarkModel : public KeyedService,
typedef std::map<const BookmarkNode*, std::string> NodeToIdMap;
// BaseBookmarkModelObserver:
- virtual void BookmarkModelChanged() override;
- virtual void BookmarkModelLoaded(BookmarkModel* model,
- bool ids_reassigned) override;
- virtual void BookmarkNodeAdded(BookmarkModel* model,
- const BookmarkNode* parent,
- int index) override;
- virtual void BookmarkNodeRemoved(BookmarkModel* model,
- const BookmarkNode* parent,
- int old_index,
- const BookmarkNode* node,
+ void BookmarkModelChanged() override;
+ void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;
+ void BookmarkNodeAdded(BookmarkModel* model,
+ const BookmarkNode* parent,
+ int index) override;
+ void BookmarkNodeRemoved(BookmarkModel* model,
+ const BookmarkNode* parent,
+ int old_index,
+ const BookmarkNode* node,
+ const std::set<GURL>& removed_urls) override;
+ void OnWillChangeBookmarkMetaInfo(BookmarkModel* model,
+ const BookmarkNode* node) override;
+ void BookmarkMetaInfoChanged(BookmarkModel* model,
+ const BookmarkNode* node) override;
+ void BookmarkAllUserNodesRemoved(BookmarkModel* model,
const std::set<GURL>& removed_urls) override;
- virtual void OnWillChangeBookmarkMetaInfo(BookmarkModel* model,
- const BookmarkNode* node) override;
- virtual void BookmarkMetaInfoChanged(BookmarkModel* model,
- const BookmarkNode* node) override;
- virtual void BookmarkAllUserNodesRemoved(
- BookmarkModel* model,
- const std::set<GURL>& removed_urls) override;
// Initialize the mapping from remote ids to nodes.
void InitializeIdMap();

Powered by Google App Engine
This is Rietveld 408576698