components/dom_distiller/core/distiller.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/distiller.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/core/distilled_page_prefs_unittests.cc ('k') | components/dom_distiller/core/distiller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/distiller.h

diff --git a/components/dom_distiller/core/distiller.h b/components/dom_distiller/core/distiller.h

index 425eed8e4c79a925f6cc0f3d55cf684cda2f4186..9f959dbca4703ce14e82fcb3801fa7a2d6a66859 100644

--- a/components/dom_distiller/core/distiller.h

+++ b/components/dom_distiller/core/distiller.h

@@ -58,8 +58,8 @@ class DistillerFactoryImpl : public DistillerFactory {

DistillerFactoryImpl(

scoped_ptr<DistillerURLFetcherFactory> distiller_url_fetcher_factory,

const dom_distiller::proto::DomDistillerOptions& dom_distiller_options);

- virtual ~DistillerFactoryImpl();

- virtual scoped_ptr<Distiller> CreateDistiller() override;

+ ~DistillerFactoryImpl() override;

+ scoped_ptr<Distiller> CreateDistiller() override;

private:

scoped_ptr<DistillerURLFetcherFactory> distiller_url_fetcher_factory_;

@@ -72,13 +72,12 @@ class DistillerImpl : public Distiller {

DistillerImpl(

const DistillerURLFetcherFactory& distiller_url_fetcher_factory,

const dom_distiller::proto::DomDistillerOptions& dom_distiller_options);

- virtual ~DistillerImpl();

+ ~DistillerImpl() override;

- virtual void DistillPage(

- const GURL& url,

- scoped_ptr<DistillerPage> distiller_page,

- const DistillationFinishedCallback& finished_cb,

- const DistillationUpdateCallback& update_cb) override;

+ void DistillPage(const GURL& url,

+ scoped_ptr<DistillerPage> distiller_page,

+ const DistillationFinishedCallback& finished_cb,

+ const DistillationUpdateCallback& update_cb) override;

void SetMaxNumPagesInArticle(size_t max_num_pages);