components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_params_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h

index 10c0992b2b6faf0e304a769deed2f2231d0db59e..c610a89f2c9833f6140b069f4319f5ca431b587c 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h

@@ -28,25 +28,23 @@ class DataReductionProxyDelegate : public net::ProxyDelegate {

explicit DataReductionProxyDelegate(

DataReductionProxyAuthRequestHandler* auth_handler);

- virtual ~DataReductionProxyDelegate();

+ ~DataReductionProxyDelegate() override;

- virtual void OnResolveProxy(const GURL& url,

- int load_flags,

- const net::ProxyService& proxy_service,

- net::ProxyInfo* result) override;

+ void OnResolveProxy(const GURL& url,

+ int load_flags,

+ const net::ProxyService& proxy_service,

+ net::ProxyInfo* result) override;

- virtual void OnFallback(const net::ProxyServer& bad_proxy,

- int net_error) override;

+ void OnFallback(const net::ProxyServer& bad_proxy, int net_error) override;

- virtual void OnBeforeSendHeaders(net::URLRequest* request,

- const net::ProxyInfo& proxy_info,

- net::HttpRequestHeaders* headers) override;

+ void OnBeforeSendHeaders(net::URLRequest* request,

+ const net::ProxyInfo& proxy_info,

+ net::HttpRequestHeaders* headers) override;

- virtual void OnBeforeTunnelRequest(

- const net::HostPortPair& proxy_server,

- net::HttpRequestHeaders* extra_headers) override;

+ void OnBeforeTunnelRequest(const net::HostPortPair& proxy_server,

+ net::HttpRequestHeaders* extra_headers) override;

- virtual void OnTunnelHeadersReceived(

+ void OnTunnelHeadersReceived(

const net::HostPortPair& origin,

const net::HostPortPair& proxy_server,

const net::HttpResponseHeaders& response_headers) override;