components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/crash/app/breakpad_mac.mm ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc

index bf7d888003de4fbf57b101cf01b5e3b3bcf08193..4d4d0935323996ebe875656977eed182de06d555 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc

@@ -100,15 +100,13 @@ class TestDataReductionProxyAuthRequestHandler

: DataReductionProxyAuthRequestHandler(

client, version, params, loop_proxy) {}

- virtual std::string GetDefaultKey() const override {

- return kTestKey;

- }

+ std::string GetDefaultKey() const override { return kTestKey; }

- virtual base::Time Now() const override {

+ base::Time Now() const override {

return base::Time::UnixEpoch() + now_offset_;

}

- virtual void RandBytes(void* output, size_t length) override {

+ void RandBytes(void* output, size_t length) override {

char* c = static_cast<char*>(output);

for (size_t i = 0; i < length; ++i) {

c[i] = 'a';