components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_observable_provider.h ('k') | components/content_settings/core/browser/content_settings_rule.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc

diff --git a/components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc b/components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc

index 7a404db206ca7a13f6f2f831abbfd4c9a47b1714..5d887a690cd984caaa9980c9b555f622f547b256 100644

--- a/components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc

+++ b/components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc

@@ -30,13 +30,11 @@ class RuleIteratorImpl : public RuleIterator {

rule_end_(rule_end),

auto_lock_(auto_lock) {

}

- virtual ~RuleIteratorImpl() {}

+ ~RuleIteratorImpl() override {}

- virtual bool HasNext() const override {

- return (current_rule_ != rule_end_);

- }

+ bool HasNext() const override { return (current_rule_ != rule_end_); }

- virtual Rule Next() override {

+ Rule Next() override {

DCHECK(current_rule_ != rule_end_);

DCHECK(current_rule_->second.get());

Rule to_return(current_rule_->first.primary_pattern,