components/component_updater/request_sender.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/request_sender.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/component_updater/default_component_installer.h ('k') | components/component_updater/test/test_configurator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/request_sender.h

diff --git a/components/component_updater/request_sender.h b/components/component_updater/request_sender.h

index 2abcf474bf1754dbfe3e8b56f86410a79b77affe..10a26f8256cdad3ae9f64cec3d46c8bed42236f9 100644

--- a/components/component_updater/request_sender.h

+++ b/components/component_updater/request_sender.h

@@ -34,7 +34,7 @@ class RequestSender : public net::URLFetcherDelegate {

RequestSenderCallback;

explicit RequestSender(const Configurator& config);

- virtual ~RequestSender();

+ ~RequestSender() override;

void Send(const std::string& request_string,

const std::vector<GURL>& urls,

@@ -44,7 +44,7 @@ class RequestSender : public net::URLFetcherDelegate {

void SendInternal();

// Overrides for URLFetcherDelegate.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

const Configurator& config_;

std::vector<GURL> urls_;