Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/component_updater/component_updater_service.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/component_updater/component_updater_service.cc
diff --git a/components/component_updater/component_updater_service.cc b/components/component_updater/component_updater_service.cc
index 4cd4a7aa4030d1e127cbdc9ea820fa3a54cf72b6..92f138146a36ea879970299155a644d411092c3b 100644
--- a/components/component_updater/component_updater_service.cc
+++ b/components/component_updater/component_updater_service.cc
@@ -103,20 +103,19 @@ CrxComponent::~CrxComponent() {
class CrxUpdateService : public ComponentUpdateService, public OnDemandUpdater {
public:
explicit CrxUpdateService(Configurator* config);
- virtual ~CrxUpdateService();
+ ~CrxUpdateService() override;
// Overrides for ComponentUpdateService.
- virtual void AddObserver(Observer* observer) override;
- virtual void RemoveObserver(Observer* observer) override;
- virtual Status Start() override;
- virtual Status Stop() override;
- virtual Status RegisterComponent(const CrxComponent& component) override;
- virtual std::vector<std::string> GetComponentIDs() const override;
- virtual OnDemandUpdater& GetOnDemandUpdater() override;
- virtual void MaybeThrottle(const std::string& crx_id,
- const base::Closure& callback) override;
- virtual scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner()
- override;
+ void AddObserver(Observer* observer) override;
+ void RemoveObserver(Observer* observer) override;
+ Status Start() override;
+ Status Stop() override;
+ Status RegisterComponent(const CrxComponent& component) override;
+ std::vector<std::string> GetComponentIDs() const override;
+ OnDemandUpdater& GetOnDemandUpdater() override;
+ void MaybeThrottle(const std::string& crx_id,
+ const base::Closure& callback) override;
+ scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner() override;
// Context for a crx download url request.
struct CRXContext {
@@ -142,11 +141,11 @@ class CrxUpdateService : public ComponentUpdateService, public OnDemandUpdater {
};
// Overrides for ComponentUpdateService.
- virtual bool GetComponentDetails(const std::string& component_id,
- CrxUpdateItem* item) const override;
+ bool GetComponentDetails(const std::string& component_id,
+ CrxUpdateItem* item) const override;
// Overrides for OnDemandUpdater.
- virtual Status OnDemandUpdate(const std::string& component_id) override;
+ Status OnDemandUpdate(const std::string& component_id) override;
void UpdateCheckComplete(const GURL& original_url,
int error,
« no previous file with comments | « components/component_updater/component_patcher_operation.h ('k') | components/component_updater/default_component_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698