components/autofill/core/browser/personal_data_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/name_field.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.h

diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h

index 9794e8e2560f9898b6180e3a4a3ec012c01f064c..49ef30a3949057fd853efe242254ffd17d9ab666 100644

--- a/components/autofill/core/browser/personal_data_manager.h

+++ b/components/autofill/core/browser/personal_data_manager.h

@@ -53,7 +53,7 @@ class PersonalDataManager : public KeyedService,

typedef std::pair<std::string, size_t> GUIDPair;

explicit PersonalDataManager(const std::string& app_locale);

- virtual ~PersonalDataManager();

+ ~PersonalDataManager() override;

// Kicks off asynchronous loading of profiles and credit cards.

// |pref_service| must outlive this instance. |is_off_the_record| informs

@@ -64,12 +64,11 @@ class PersonalDataManager : public KeyedService,

bool is_off_the_record);

// WebDataServiceConsumer:

- virtual void OnWebDataServiceRequestDone(

- WebDataServiceBase::Handle h,

- const WDTypedResult* result) override;

+ void OnWebDataServiceRequestDone(WebDataServiceBase::Handle h,

+ const WDTypedResult* result) override;

// AutofillWebDataServiceObserverOnUIThread:

- virtual void AutofillMultipleChanged() override;

+ void AutofillMultipleChanged() override;

// Adds a listener to be notified of PersonalDataManager events.

virtual void AddObserver(PersonalDataManagerObserver* observer);