Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: components/autofill/core/browser/contact_info.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/contact_info.h
diff --git a/components/autofill/core/browser/contact_info.h b/components/autofill/core/browser/contact_info.h
index cfb56ec16887a5eabe0bcb871b59ef8c6d6a3333..1e3adc34ca2f93ad425c4a4562d4ab5593b872c8 100644
--- a/components/autofill/core/browser/contact_info.h
+++ b/components/autofill/core/browser/contact_info.h
@@ -19,7 +19,7 @@ class NameInfo : public FormGroup {
public:
NameInfo();
NameInfo(const NameInfo& info);
- virtual ~NameInfo();
+ ~NameInfo() override;
NameInfo& operator=(const NameInfo& info);
@@ -28,19 +28,17 @@ class NameInfo : public FormGroup {
bool ParsedNamesAreEqual(const NameInfo& info);
// FormGroup:
- virtual base::string16 GetRawInfo(ServerFieldType type) const override;
- virtual void SetRawInfo(ServerFieldType type,
- const base::string16& value) override;
- virtual base::string16 GetInfo(const AutofillType& type,
- const std::string& app_locale) const override;
- virtual bool SetInfo(const AutofillType& type,
- const base::string16& value,
- const std::string& app_locale) override;
+ base::string16 GetRawInfo(ServerFieldType type) const override;
+ void SetRawInfo(ServerFieldType type, const base::string16& value) override;
+ base::string16 GetInfo(const AutofillType& type,
+ const std::string& app_locale) const override;
+ bool SetInfo(const AutofillType& type,
+ const base::string16& value,
+ const std::string& app_locale) override;
private:
// FormGroup:
- virtual void GetSupportedTypes(
- ServerFieldTypeSet* supported_types) const override;
+ void GetSupportedTypes(ServerFieldTypeSet* supported_types) const override;
// Returns the full name, which is either |full_|, or if |full_| is empty,
// is composed of given, middle and family.
@@ -63,19 +61,17 @@ class EmailInfo : public FormGroup {
public:
EmailInfo();
EmailInfo(const EmailInfo& info);
- virtual ~EmailInfo();
+ ~EmailInfo() override;
EmailInfo& operator=(const EmailInfo& info);
// FormGroup:
- virtual base::string16 GetRawInfo(ServerFieldType type) const override;
- virtual void SetRawInfo(ServerFieldType type,
- const base::string16& value) override;
+ base::string16 GetRawInfo(ServerFieldType type) const override;
+ void SetRawInfo(ServerFieldType type, const base::string16& value) override;
private:
// FormGroup:
- virtual void GetSupportedTypes(
- ServerFieldTypeSet* supported_types) const override;
+ void GetSupportedTypes(ServerFieldTypeSet* supported_types) const override;
base::string16 email_;
};
@@ -84,19 +80,17 @@ class CompanyInfo : public FormGroup {
public:
CompanyInfo();
CompanyInfo(const CompanyInfo& info);
- virtual ~CompanyInfo();
+ ~CompanyInfo() override;
CompanyInfo& operator=(const CompanyInfo& info);
// FormGroup:
- virtual base::string16 GetRawInfo(ServerFieldType type) const override;
- virtual void SetRawInfo(ServerFieldType type,
- const base::string16& value) override;
+ base::string16 GetRawInfo(ServerFieldType type) const override;
+ void SetRawInfo(ServerFieldType type, const base::string16& value) override;
private:
// FormGroup:
- virtual void GetSupportedTypes(
- ServerFieldTypeSet* supported_types) const override;
+ void GetSupportedTypes(ServerFieldTypeSet* supported_types) const override;
base::string16 company_name_;
};
« no previous file with comments | « components/autofill/core/browser/autofill_xml_parser.h ('k') | components/autofill/core/browser/credit_card.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698