components/autofill/core/browser/autofill_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_external_delegate.h ('k') | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index 22b3983840ac5016c88b9d2e0022ed8baa7ad301..cdbb62537aaf3b61bc5f4207075634a90683144d 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -73,7 +73,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

AutofillClient* client,

const std::string& app_locale,

AutofillDownloadManagerState enable_download_manager);

- virtual ~AutofillManager();

+ ~AutofillManager() override;

// Sets an external delegate.

void SetExternalDelegate(AutofillExternalDelegate* delegate);

@@ -214,8 +214,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

private:

// AutofillDownloadManager::Observer:

- virtual void OnLoadedServerPredictions(

- const std::string& response_xml) override;

+ void OnLoadedServerPredictions(const std::string& response_xml) override;

// Returns false if Autofill is disabled or if no Autofill data is available.

bool RefreshDataModels() const;