components/autofill/core/browser/autofill_download_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_download_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_data_model_unittest.cc ('k') | components/autofill/core/browser/autofill_download_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_download_manager.h

diff --git a/components/autofill/core/browser/autofill_download_manager.h b/components/autofill/core/browser/autofill_download_manager.h

index 2963e413f92a9a6e717b9eb132cee1394f81fd3e..4f0e2a33227fd0e4c0e3de545b16c6015b86c903 100644

--- a/components/autofill/core/browser/autofill_download_manager.h

+++ b/components/autofill/core/browser/autofill_download_manager.h

@@ -63,7 +63,7 @@ class AutofillDownloadManager : public net::URLFetcherDelegate {

AutofillDownloadManager(AutofillDriver* driver,

PrefService* pref_service,

Observer* observer);

- virtual ~AutofillDownloadManager();

+ ~AutofillDownloadManager() override;

// Starts a query request to Autofill servers. The observer is called with the

// list of the fields of all requested forms.

@@ -118,7 +118,7 @@ class AutofillDownloadManager : public net::URLFetcherDelegate {

const std::vector<std::string>& forms_in_query) const;

// net::URLFetcherDelegate implementation:

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// Probability of the form upload. Between 0 (no upload) and 1 (upload all).

// GetPositiveUploadRate() is for matched forms,