components/autofill/content/renderer/renderer_save_password_progress_logger.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/renderer_save_password_progress_logger.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_generation_agent.h ('k') | components/autofill/content/renderer/test_password_autofill_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/renderer_save_password_progress_logger.h

diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger.h b/components/autofill/content/renderer/renderer_save_password_progress_logger.h

index 2cc9e70b36d4992332875267cb2dea1747cb2425..a636371b51345ac11d66eb49cae281dba0f6130f 100644

--- a/components/autofill/content/renderer/renderer_save_password_progress_logger.h

+++ b/components/autofill/content/renderer/renderer_save_password_progress_logger.h

@@ -25,11 +25,11 @@ class RendererSavePasswordProgressLogger : public SavePasswordProgressLogger {

// AutofillHostMsg_RecordSavePasswordProgress message with the logs to the

// browser. The |sender| needs to outlive the constructed logger.

RendererSavePasswordProgressLogger(IPC::Sender* sender, int routing_id);

- virtual ~RendererSavePasswordProgressLogger();

+ ~RendererSavePasswordProgressLogger() override;

protected:

// SavePasswordProgressLogger:

- virtual void SendLog(const std::string& log) override;

+ void SendLog(const std::string& log) override;

private:

// Used by SendLog to send the IPC message with logs. |sender_| needs to