components/autofill/content/renderer/autofill_agent.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/wallet/wallet_signin_helper.h ('k') | components/autofill/content/renderer/page_click_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.h

diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h

index 22c70bb762c3d67601f82fd763a05327941041ab..8ed72c115f820fe231af1d85813dc645bb9600a0 100644

--- a/components/autofill/content/renderer/autofill_agent.h

+++ b/components/autofill/content/renderer/autofill_agent.h

@@ -56,23 +56,22 @@ class AutofillAgent : public content::RenderViewObserver,

private:

// content::RenderViewObserver:

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void DidFinishDocumentLoad(blink::WebLocalFrame* frame) override;

- virtual void DidCommitProvisionalLoad(blink::WebLocalFrame* frame,

- bool is_new_navigation) override;

- virtual void FrameDetached(blink::WebFrame* frame) override;

- virtual void FrameWillClose(blink::WebFrame* frame) override;

- virtual void WillSubmitForm(blink::WebLocalFrame* frame,

- const blink::WebFormElement& form) override;

- virtual void DidChangeScrollOffset(blink::WebLocalFrame* frame) override;

- virtual void FocusedNodeChanged(const blink::WebNode& node) override;

- virtual void OrientationChangeEvent() override;

- virtual void Resized() override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void DidFinishDocumentLoad(blink::WebLocalFrame* frame) override;

+ void DidCommitProvisionalLoad(blink::WebLocalFrame* frame,

+ bool is_new_navigation) override;

+ void FrameDetached(blink::WebFrame* frame) override;

+ void FrameWillClose(blink::WebFrame* frame) override;

+ void WillSubmitForm(blink::WebLocalFrame* frame,

+ const blink::WebFormElement& form) override;

+ void DidChangeScrollOffset(blink::WebLocalFrame* frame) override;

+ void FocusedNodeChanged(const blink::WebNode& node) override;

+ void OrientationChangeEvent() override;

+ void Resized() override;

// PageClickListener:

- virtual void FormControlElementClicked(

- const blink::WebFormControlElement& element,

- bool was_focused) override;

+ void FormControlElementClicked(const blink::WebFormControlElement& element,

+ bool was_focused) override;

// blink::WebAutofillClient:

virtual void textFieldDidEndEditing(