Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: components/translate/core/browser/language_state_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/language_state.h" 5 #include "components/translate/core/browser/language_state.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "components/translate/core/browser/language_state.h" 8 #include "components/translate/core/browser/language_state.h"
9 #include "components/translate/core/browser/translate_driver.h" 9 #include "components/translate/core/browser/translate_driver.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 13 matching lines...) Expand all
24 language_state_(this) { 24 language_state_(this) {
25 } 25 }
26 26
27 void Reset() { 27 void Reset() {
28 on_is_page_translated_changed_called_ = false; 28 on_is_page_translated_changed_called_ = false;
29 on_translate_enabled_changed_called_ = false; 29 on_translate_enabled_changed_called_ = false;
30 } 30 }
31 31
32 virtual ~MockTranslateDriver() {} 32 virtual ~MockTranslateDriver() {}
33 33
34 virtual void OnIsPageTranslatedChanged() override { 34 void OnIsPageTranslatedChanged() override {
35 on_is_page_translated_changed_called_ = true; 35 on_is_page_translated_changed_called_ = true;
36 } 36 }
37 37
38 virtual void OnTranslateEnabledChanged() override { 38 void OnTranslateEnabledChanged() override {
39 on_translate_enabled_changed_called_ = true; 39 on_translate_enabled_changed_called_ = true;
40 } 40 }
41 41
42 virtual bool IsLinkNavigation() override { 42 bool IsLinkNavigation() override { return false; }
43 return false;
44 }
45 43
46 virtual void TranslatePage(int page_seq_no, 44 void TranslatePage(int page_seq_no,
47 const std::string& translate_script, 45 const std::string& translate_script,
48 const std::string& source_lang, 46 const std::string& source_lang,
49 const std::string& target_lang) override {} 47 const std::string& target_lang) override {}
50 48
51 virtual void RevertTranslation(int page_seq_no) override {} 49 void RevertTranslation(int page_seq_no) override {}
52 50
53 virtual bool IsOffTheRecord() override { return false; } 51 bool IsOffTheRecord() override { return false; }
54 52
55 virtual const std::string& GetContentsMimeType() override { 53 const std::string& GetContentsMimeType() override { return kHtmlMimeType; }
56 return kHtmlMimeType;
57 }
58 54
59 virtual const GURL& GetLastCommittedURL() override { 55 const GURL& GetLastCommittedURL() override { return GURL::EmptyGURL(); }
60 return GURL::EmptyGURL();
61 }
62 56
63 virtual const GURL& GetActiveURL() override { return GURL::EmptyGURL(); } 57 const GURL& GetActiveURL() override { return GURL::EmptyGURL(); }
64 58
65 virtual const GURL& GetVisibleURL() override { return GURL::EmptyGURL(); } 59 const GURL& GetVisibleURL() override { return GURL::EmptyGURL(); }
66 60
67 virtual bool HasCurrentPage() override { return true; } 61 bool HasCurrentPage() override { return true; }
68 62
69 virtual void OpenUrlInNewTab(const GURL& url) override {} 63 void OpenUrlInNewTab(const GURL& url) override {}
70 64
71 bool on_is_page_translated_changed_called() const { 65 bool on_is_page_translated_changed_called() const {
72 return on_is_page_translated_changed_called_; 66 return on_is_page_translated_changed_called_;
73 } 67 }
74 68
75 bool on_translate_enabled_changed_called() const { 69 bool on_translate_enabled_changed_called() const {
76 return on_translate_enabled_changed_called_; 70 return on_translate_enabled_changed_called_;
77 } 71 }
78 72
79 private: 73 private:
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 language_state.SetCurrentLanguage("en"); 134 language_state.SetCurrentLanguage("en");
141 EXPECT_TRUE(language_state.IsPageTranslated()); 135 EXPECT_TRUE(language_state.IsPageTranslated());
142 EXPECT_TRUE(driver->on_is_page_translated_changed_called()); 136 EXPECT_TRUE(driver->on_is_page_translated_changed_called());
143 137
144 // Translate feature must be enabled after an actual translation. 138 // Translate feature must be enabled after an actual translation.
145 EXPECT_TRUE(language_state.translate_enabled()); 139 EXPECT_TRUE(language_state.translate_enabled());
146 EXPECT_TRUE(driver->on_translate_enabled_changed_called()); 140 EXPECT_TRUE(driver->on_translate_enabled_changed_called());
147 } 141 }
148 142
149 } // namespace translate 143 } // namespace translate
OLDNEW
« no previous file with comments | « components/translate/content/renderer/translate_helper.h ('k') | components/translate/core/browser/options_menu_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698