Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: components/search_engines/template_url_parser_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_util.h" 5 #include "base/files/file_util.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/common/chrome_paths.h" 9 #include "chrome/common/chrome_paths.h"
10 #include "components/search_engines/search_terms_data.h" 10 #include "components/search_engines/search_terms_data.h"
11 #include "components/search_engines/template_url.h" 11 #include "components/search_engines/template_url.h"
12 #include "components/search_engines/template_url_parser.h" 12 #include "components/search_engines/template_url_parser.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 using base::ASCIIToUTF16; 15 using base::ASCIIToUTF16;
16 16
17 // ParamFilterImpl ------------------------------------------------------------ 17 // ParamFilterImpl ------------------------------------------------------------
18 18
19 // Filters any param which as an occurrence of name_str_ in its name or an 19 // Filters any param which as an occurrence of name_str_ in its name or an
20 // occurrence of value_str_ in its value. 20 // occurrence of value_str_ in its value.
21 class ParamFilterImpl : public TemplateURLParser::ParameterFilter { 21 class ParamFilterImpl : public TemplateURLParser::ParameterFilter {
22 public: 22 public:
23 ParamFilterImpl(std::string name_str, std::string value_str); 23 ParamFilterImpl(std::string name_str, std::string value_str);
24 virtual ~ParamFilterImpl(); 24 ~ParamFilterImpl() override;
25 25
26 virtual bool KeepParameter(const std::string& key, 26 bool KeepParameter(const std::string& key, const std::string& value) override;
27 const std::string& value) override;
28 27
29 private: 28 private:
30 std::string name_str_; 29 std::string name_str_;
31 std::string value_str_; 30 std::string value_str_;
32 31
33 DISALLOW_COPY_AND_ASSIGN(ParamFilterImpl); 32 DISALLOW_COPY_AND_ASSIGN(ParamFilterImpl);
34 }; 33 };
35 34
36 ParamFilterImpl::ParamFilterImpl(std::string name_str, std::string value_str) 35 ParamFilterImpl::ParamFilterImpl(std::string name_str, std::string value_str)
37 : name_str_(name_str), 36 : name_str_(name_str),
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 EXPECT_EQ(ASCIIToUTF16("Yahoo"), template_url_->short_name()); 253 EXPECT_EQ(ASCIIToUTF16("Yahoo"), template_url_->short_name());
255 EXPECT_TRUE(template_url_->url_ref().SupportsReplacement(SearchTermsData())); 254 EXPECT_TRUE(template_url_->url_ref().SupportsReplacement(SearchTermsData()));
256 EXPECT_TRUE(template_url_->suggestions_url().empty()); 255 EXPECT_TRUE(template_url_->suggestions_url().empty());
257 EXPECT_EQ("http://search.yahoo.com/search?p={searchTerms}&ei=UTF-8", 256 EXPECT_EQ("http://search.yahoo.com/search?p={searchTerms}&ei=UTF-8",
258 template_url_->url()); 257 template_url_->url());
259 ASSERT_EQ(1U, template_url_->input_encodings().size()); 258 ASSERT_EQ(1U, template_url_->input_encodings().size());
260 EXPECT_EQ("UTF-8", template_url_->input_encodings()[0]); 259 EXPECT_EQ("UTF-8", template_url_->input_encodings()[0]);
261 EXPECT_EQ(GURL("http://search.yahoo.com/favicon.ico"), 260 EXPECT_EQ(GURL("http://search.yahoo.com/favicon.ico"),
262 template_url_->favicon_url()); 261 template_url_->favicon_url());
263 } 262 }
OLDNEW
« no previous file with comments | « components/search_engines/template_url_fetcher.cc ('k') | components/search_engines/template_url_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698