Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: components/nacl/browser/nacl_file_host_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/browser/nacl_file_host.h" 5 #include "components/nacl/browser/nacl_file_host.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/test/scoped_path_override.h" 10 #include "base/test/scoped_path_override.h"
11 #include "components/nacl/browser/nacl_browser.h" 11 #include "components/nacl/browser/nacl_browser.h"
12 #include "components/nacl/browser/nacl_browser_delegate.h" 12 #include "components/nacl/browser/nacl_browser_delegate.h"
13 #include "components/nacl/browser/test_nacl_browser_delegate.h" 13 #include "components/nacl/browser/test_nacl_browser_delegate.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 using nacl_file_host::PnaclCanOpenFile; 16 using nacl_file_host::PnaclCanOpenFile;
17 17
18 class FileHostTestNaClBrowserDelegate : public TestNaClBrowserDelegate { 18 class FileHostTestNaClBrowserDelegate : public TestNaClBrowserDelegate {
19 public: 19 public:
20 FileHostTestNaClBrowserDelegate() {} 20 FileHostTestNaClBrowserDelegate() {}
21 21
22 virtual bool GetPnaclDirectory(base::FilePath* pnacl_dir) override { 22 bool GetPnaclDirectory(base::FilePath* pnacl_dir) override {
23 *pnacl_dir = pnacl_path_; 23 *pnacl_dir = pnacl_path_;
24 return true; 24 return true;
25 } 25 }
26 26
27 void SetPnaclDirectory(const base::FilePath& pnacl_dir) { 27 void SetPnaclDirectory(const base::FilePath& pnacl_dir) {
28 pnacl_path_ = pnacl_dir; 28 pnacl_path_ = pnacl_dir;
29 } 29 }
30 30
31 private: 31 private:
32 base::FilePath pnacl_path_; 32 base::FilePath pnacl_path_;
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 EXPECT_FALSE(PnaclCanOpenFile("..\\llc", &out_path)); 110 EXPECT_FALSE(PnaclCanOpenFile("..\\llc", &out_path));
111 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%", &out_path)); 111 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%", &out_path));
112 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%\\explorer.exe", &out_path)); 112 EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%\\explorer.exe", &out_path));
113 #else 113 #else
114 EXPECT_FALSE(PnaclCanOpenFile("../llc", &out_path)); 114 EXPECT_FALSE(PnaclCanOpenFile("../llc", &out_path));
115 EXPECT_FALSE(PnaclCanOpenFile("/bin/sh", &out_path)); 115 EXPECT_FALSE(PnaclCanOpenFile("/bin/sh", &out_path));
116 EXPECT_FALSE(PnaclCanOpenFile("$HOME", &out_path)); 116 EXPECT_FALSE(PnaclCanOpenFile("$HOME", &out_path));
117 EXPECT_FALSE(PnaclCanOpenFile("$HOME/.bashrc", &out_path)); 117 EXPECT_FALSE(PnaclCanOpenFile("$HOME/.bashrc", &out_path));
118 #endif 118 #endif
119 } 119 }
OLDNEW
« no previous file with comments | « components/metrics/test_metrics_service_client.h ('k') | components/nacl/browser/nacl_host_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698