Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: components/metrics/daily_event_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/metrics/daily_event.h" 5 #include "components/metrics/daily_event.h"
6 6
7 #include "base/prefs/testing_pref_service.h" 7 #include "base/prefs/testing_pref_service.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace metrics { 10 namespace metrics {
11 11
12 namespace { 12 namespace {
13 13
14 const char kTestPrefName[] = "TestPref"; 14 const char kTestPrefName[] = "TestPref";
15 const char kTestMetricName[] = "TestMetric"; 15 const char kTestMetricName[] = "TestMetric";
16 16
17 class TestDailyObserver : public DailyEvent::Observer { 17 class TestDailyObserver : public DailyEvent::Observer {
18 public: 18 public:
19 TestDailyObserver() : fired_(false) {} 19 TestDailyObserver() : fired_(false) {}
20 20
21 bool fired() const { return fired_; } 21 bool fired() const { return fired_; }
22 22
23 virtual void OnDailyEvent() override { 23 void OnDailyEvent() override { fired_ = true; }
24 fired_ = true;
25 }
26 24
27 void Reset() { 25 void Reset() {
28 fired_ = false; 26 fired_ = false;
29 } 27 }
30 28
31 private: 29 private:
32 // True if this event has been observed. 30 // True if this event has been observed.
33 bool fired_; 31 bool fired_;
34 32
35 DISALLOW_COPY_AND_ASSIGN(TestDailyObserver); 33 DISALLOW_COPY_AND_ASSIGN(TestDailyObserver);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 85
88 // The event should not fire if the preference is less than a day in the future. 86 // The event should not fire if the preference is less than a day in the future.
89 TEST_F(DailyEventTest, TestSoonNotFired) { 87 TEST_F(DailyEventTest, TestSoonNotFired) {
90 base::Time last_time = base::Time::Now() + base::TimeDelta::FromMinutes(2); 88 base::Time last_time = base::Time::Now() + base::TimeDelta::FromMinutes(2);
91 prefs_.SetInt64(kTestPrefName, last_time.ToInternalValue()); 89 prefs_.SetInt64(kTestPrefName, last_time.ToInternalValue());
92 event_.CheckInterval(); 90 event_.CheckInterval();
93 EXPECT_FALSE(observer_->fired()); 91 EXPECT_FALSE(observer_->fired());
94 } 92 }
95 93
96 } // namespace metrics 94 } // namespace metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698