Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Side by Side Diff: components/bookmarks/browser/bookmark_model_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/bookmarks/browser/bookmark_model.h" 5 #include "components/bookmarks/browser/bookmark_model.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_paths.h" 10 #include "base/base_paths.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 const BookmarkNode* node2_; 137 const BookmarkNode* node2_;
138 int index1_; 138 int index1_;
139 int index2_; 139 int index2_;
140 }; 140 };
141 141
142 BookmarkModelTest() : model_(client_.CreateModel()) { 142 BookmarkModelTest() : model_(client_.CreateModel()) {
143 model_->AddObserver(this); 143 model_->AddObserver(this);
144 ClearCounts(); 144 ClearCounts();
145 } 145 }
146 146
147 virtual void BookmarkModelLoaded(BookmarkModel* model, 147 void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override {
148 bool ids_reassigned) override {
149 // We never load from the db, so that this should never get invoked. 148 // We never load from the db, so that this should never get invoked.
150 NOTREACHED(); 149 NOTREACHED();
151 } 150 }
152 151
153 virtual void BookmarkNodeMoved(BookmarkModel* model, 152 void BookmarkNodeMoved(BookmarkModel* model,
154 const BookmarkNode* old_parent, 153 const BookmarkNode* old_parent,
155 int old_index, 154 int old_index,
156 const BookmarkNode* new_parent, 155 const BookmarkNode* new_parent,
157 int new_index) override { 156 int new_index) override {
158 ++moved_count_; 157 ++moved_count_;
159 observer_details_.Set(old_parent, new_parent, old_index, new_index); 158 observer_details_.Set(old_parent, new_parent, old_index, new_index);
160 } 159 }
161 160
162 virtual void BookmarkNodeAdded(BookmarkModel* model, 161 void BookmarkNodeAdded(BookmarkModel* model,
163 const BookmarkNode* parent, 162 const BookmarkNode* parent,
164 int index) override { 163 int index) override {
165 ++added_count_; 164 ++added_count_;
166 observer_details_.Set(parent, NULL, index, -1); 165 observer_details_.Set(parent, NULL, index, -1);
167 } 166 }
168 167
169 virtual void OnWillRemoveBookmarks(BookmarkModel* model, 168 void OnWillRemoveBookmarks(BookmarkModel* model,
170 const BookmarkNode* parent, 169 const BookmarkNode* parent,
171 int old_index, 170 int old_index,
172 const BookmarkNode* node) override { 171 const BookmarkNode* node) override {
173 ++before_remove_count_; 172 ++before_remove_count_;
174 } 173 }
175 174
176 virtual void BookmarkNodeRemoved( 175 void BookmarkNodeRemoved(BookmarkModel* model,
177 BookmarkModel* model, 176 const BookmarkNode* parent,
178 const BookmarkNode* parent, 177 int old_index,
179 int old_index, 178 const BookmarkNode* node,
180 const BookmarkNode* node, 179 const std::set<GURL>& removed_urls) override {
181 const std::set<GURL>& removed_urls) override {
182 ++removed_count_; 180 ++removed_count_;
183 observer_details_.Set(parent, NULL, old_index, -1); 181 observer_details_.Set(parent, NULL, old_index, -1);
184 } 182 }
185 183
186 virtual void BookmarkNodeChanged(BookmarkModel* model, 184 void BookmarkNodeChanged(BookmarkModel* model,
187 const BookmarkNode* node) override { 185 const BookmarkNode* node) override {
188 ++changed_count_; 186 ++changed_count_;
189 observer_details_.Set(node, NULL, -1, -1); 187 observer_details_.Set(node, NULL, -1, -1);
190 } 188 }
191 189
192 virtual void OnWillChangeBookmarkNode(BookmarkModel* model, 190 void OnWillChangeBookmarkNode(BookmarkModel* model,
193 const BookmarkNode* node) override { 191 const BookmarkNode* node) override {
194 ++before_change_count_; 192 ++before_change_count_;
195 } 193 }
196 194
197 virtual void BookmarkNodeChildrenReordered( 195 void BookmarkNodeChildrenReordered(BookmarkModel* model,
198 BookmarkModel* model, 196 const BookmarkNode* node) override {
199 const BookmarkNode* node) override {
200 ++reordered_count_; 197 ++reordered_count_;
201 } 198 }
202 199
203 virtual void OnWillReorderBookmarkNode(BookmarkModel* model, 200 void OnWillReorderBookmarkNode(BookmarkModel* model,
204 const BookmarkNode* node) override { 201 const BookmarkNode* node) override {
205 ++before_reorder_count_; 202 ++before_reorder_count_;
206 } 203 }
207 204
208 virtual void BookmarkNodeFaviconChanged(BookmarkModel* model, 205 void BookmarkNodeFaviconChanged(BookmarkModel* model,
209 const BookmarkNode* node) override { 206 const BookmarkNode* node) override {
210 // We never attempt to load favicons, so that this method never 207 // We never attempt to load favicons, so that this method never
211 // gets invoked. 208 // gets invoked.
212 } 209 }
213 210
214 virtual void ExtensiveBookmarkChangesBeginning( 211 void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override {
215 BookmarkModel* model) override {
216 ++extensive_changes_beginning_count_; 212 ++extensive_changes_beginning_count_;
217 } 213 }
218 214
219 virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override { 215 void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override {
220 ++extensive_changes_ended_count_; 216 ++extensive_changes_ended_count_;
221 } 217 }
222 218
223 virtual void BookmarkAllUserNodesRemoved( 219 void BookmarkAllUserNodesRemoved(
224 BookmarkModel* model, 220 BookmarkModel* model,
225 const std::set<GURL>& removed_urls) override { 221 const std::set<GURL>& removed_urls) override {
226 ++all_bookmarks_removed_; 222 ++all_bookmarks_removed_;
227 } 223 }
228 224
229 virtual void OnWillRemoveAllUserBookmarks(BookmarkModel* model) override { 225 void OnWillRemoveAllUserBookmarks(BookmarkModel* model) override {
230 ++before_remove_all_count_; 226 ++before_remove_all_count_;
231 } 227 }
232 228
233 void ClearCounts() { 229 void ClearCounts() {
234 added_count_ = moved_count_ = removed_count_ = changed_count_ = 230 added_count_ = moved_count_ = removed_count_ = changed_count_ =
235 reordered_count_ = extensive_changes_beginning_count_ = 231 reordered_count_ = extensive_changes_beginning_count_ =
236 extensive_changes_ended_count_ = all_bookmarks_removed_ = 232 extensive_changes_ended_count_ = all_bookmarks_removed_ =
237 before_remove_count_ = before_change_count_ = before_reorder_count_ = 233 before_remove_count_ = before_change_count_ = before_reorder_count_ =
238 before_remove_all_count_ = 0; 234 before_remove_all_count_ = 0;
239 } 235 }
(...skipping 956 matching lines...) Expand 10 before | Expand all | Expand 10 after
1196 EXPECT_FALSE(node.DeleteMetaInfo("key3")); 1192 EXPECT_FALSE(node.DeleteMetaInfo("key3"));
1197 EXPECT_FALSE(node.GetMetaInfo("key1", &out_value)); 1193 EXPECT_FALSE(node.GetMetaInfo("key1", &out_value));
1198 EXPECT_FALSE(node.GetMetaInfo("key2.subkey1", &out_value)); 1194 EXPECT_FALSE(node.GetMetaInfo("key2.subkey1", &out_value));
1199 EXPECT_FALSE(node.GetMetaInfo("key2.subkey2", &out_value)); 1195 EXPECT_FALSE(node.GetMetaInfo("key2.subkey2", &out_value));
1200 EXPECT_FALSE(node.GetMetaInfo("key2.subkey2.leaf", &out_value)); 1196 EXPECT_FALSE(node.GetMetaInfo("key2.subkey2.leaf", &out_value));
1201 EXPECT_FALSE(node.GetMetaInfoMap()); 1197 EXPECT_FALSE(node.GetMetaInfoMap());
1202 } 1198 }
1203 1199
1204 } // namespace 1200 } // namespace
1205 } // namespace bookmarks 1201 } // namespace bookmarks
OLDNEW
« no previous file with comments | « components/bookmarks/browser/bookmark_model.h ('k') | components/bookmarks/browser/bookmark_node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698