components/bookmarks/browser/bookmark_client.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks/browser/bookmark_client.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/bookmarks/browser/base_bookmark_model_observer.h ('k') | components/bookmarks/browser/bookmark_expanded_state_tracker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CLIENT_H_	5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CLIENT_H_

6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CLIENT_H_	6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CLIENT_H_

7	7

8 #include <set>	8 #include <set>

9 #include <utility>	9 #include <utility>

10 #include <vector>	10 #include <vector>

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
81 // Returns true if \|node\| should sync.	81 // Returns true if \|node\| should sync.

82 virtual bool CanSyncNode(const BookmarkNode* node) = 0;	82 virtual bool CanSyncNode(const BookmarkNode* node) = 0;

83	83

84 // Returns true if this node can be edited by the user.	84 // Returns true if this node can be edited by the user.

85 // TODO(joaodasilva): the model should check this more aggressively, and	85 // TODO(joaodasilva): the model should check this more aggressively, and

86 // should give the client a means to temporarily disable those checks.	86 // should give the client a means to temporarily disable those checks.

87 // http://crbug.com/49598	87 // http://crbug.com/49598

88 virtual bool CanBeEditedByUser(const BookmarkNode* node) = 0;	88 virtual bool CanBeEditedByUser(const BookmarkNode* node) = 0;

89	89

90 protected:	90 protected:

91 virtual ~BookmarkClient() {}	91 ~BookmarkClient() override {}

92 };	92 };

93	93

94 } // namespace bookmarks	94 } // namespace bookmarks

95	95

96 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CLIENT_H_	96 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CLIENT_H_

OLD	NEW