chrome/browser/browsing_data/browsing_data_remover_test_util.h - Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_test_util.h

Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Horribleness Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_browsertest.cc ('k') | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover_test_util.h

diff --git a/chrome/browser/browsing_data/browsing_data_remover_test_util.h b/chrome/browser/browsing_data/browsing_data_remover_test_util.h

index 2994cf6010bac80e0d7b675ecdad153fde34d33c..dc7eb17bd6f2ae3c907c2fb6c046c5df72922ba1 100644

--- a/chrome/browser/browsing_data/browsing_data_remover_test_util.h

+++ b/chrome/browser/browsing_data/browsing_data_remover_test_util.h

@@ -14,13 +14,13 @@ class BrowsingDataRemoverCompletionObserver

: public BrowsingDataRemover::Observer {

public:

explicit BrowsingDataRemoverCompletionObserver(BrowsingDataRemover* remover);

- virtual ~BrowsingDataRemoverCompletionObserver();

+ ~BrowsingDataRemoverCompletionObserver() override;

void BlockUntilCompletion();

protected:

// BrowsingDataRemover::Observer:

- virtual void OnBrowsingDataRemoverDone() override;

+ void OnBrowsingDataRemoverDone() override;

private:

scoped_refptr<content::MessageLoopRunner> message_loop_runner_;

@@ -32,14 +32,14 @@ class BrowsingDataRemoverCompletionInhibitor

: public BrowsingDataRemover::CompletionInhibitor {

public:

BrowsingDataRemoverCompletionInhibitor();

- virtual ~BrowsingDataRemoverCompletionInhibitor();

+ ~BrowsingDataRemoverCompletionInhibitor() override;

void BlockUntilNearCompletion();

void ContinueToCompletion();

protected:

// BrowsingDataRemover::CompletionInhibitor:

- virtual void OnBrowsingDataRemoverWouldComplete(

+ void OnBrowsingDataRemoverWouldComplete(

BrowsingDataRemover* remover,

const base::Closure& continue_to_completion) override;