chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc - Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc

Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Horribleness Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_file_system_helper.cc ('k') | chrome/browser/browsing_data/browsing_data_indexed_db_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc

diff --git a/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc b/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc

index 325ffd009d12fefd66d6196a4dab6b0b50c89a31..d6a0fdbe116802524a5a72ec79432a3267a7e2e7 100644

--- a/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc

+++ b/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc

@@ -21,20 +21,17 @@ class BrowsingDataFlashLSOHelperImpl

content::BrowserContext* browser_context);

// BrowsingDataFlashLSOHelper implementation:

- virtual void StartFetching(

- const GetSitesWithFlashDataCallback& callback) override;

- virtual void DeleteFlashLSOsForSite(const std::string& site) override;

+ void StartFetching(const GetSitesWithFlashDataCallback& callback) override;

+ void DeleteFlashLSOsForSite(const std::string& site) override;

// PepperFlashSettingsManager::Client overrides:

- virtual void OnGetSitesWithDataCompleted(

+ void OnGetSitesWithDataCompleted(

uint32 request_id,

const std::vector<std::string>& sites) override;

- virtual void OnClearSiteDataCompleted(

- uint32 request_id,

- bool success) override;

+ void OnClearSiteDataCompleted(uint32 request_id, bool success) override;

private:

- virtual ~BrowsingDataFlashLSOHelperImpl();

+ ~BrowsingDataFlashLSOHelperImpl() override;

// Asynchronously fetches and deletes data and calls us back.

PepperFlashSettingsManager settings_manager_;