Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Horribleness Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 // Creates a BrowsingDataRemover to remove browser data from the specified 243 // Creates a BrowsingDataRemover to remove browser data from the specified
244 // profile in the specified time range. Use Remove to initiate the removal. 244 // profile in the specified time range. Use Remove to initiate the removal.
245 BrowsingDataRemover(Profile* profile, 245 BrowsingDataRemover(Profile* profile,
246 base::Time delete_begin, 246 base::Time delete_begin,
247 base::Time delete_end); 247 base::Time delete_end);
248 248
249 // BrowsingDataRemover deletes itself (using DeleteHelper) and is not supposed 249 // BrowsingDataRemover deletes itself (using DeleteHelper) and is not supposed
250 // to be deleted by other objects so make destructor private and DeleteHelper 250 // to be deleted by other objects so make destructor private and DeleteHelper
251 // a friend. 251 // a friend.
252 friend class base::DeleteHelper<BrowsingDataRemover>; 252 friend class base::DeleteHelper<BrowsingDataRemover>;
253 virtual ~BrowsingDataRemover(); 253
254 // When plugins aren't enabled, there is no base class, so adding an override
255 // specifier would result in a compile error.
256 #if defined(ENABLE_PLUGINS)
257 ~BrowsingDataRemover() override;
258 #else
259 ~BrowsingDataRemover();
260 #endif
254 261
255 // Callback for when TemplateURLService has finished loading. Clears the data, 262 // Callback for when TemplateURLService has finished loading. Clears the data,
256 // clears the respective waiting flag, and invokes NotifyAndDeleteIfDone. 263 // clears the respective waiting flag, and invokes NotifyAndDeleteIfDone.
257 void OnKeywordsLoaded(); 264 void OnKeywordsLoaded();
258 265
259 // Called when plug-in data has been cleared. Invokes NotifyAndDeleteIfDone. 266 // Called when plug-in data has been cleared. Invokes NotifyAndDeleteIfDone.
260 void OnWaitableEventSignaled(base::WaitableEvent* waitable_event); 267 void OnWaitableEventSignaled(base::WaitableEvent* waitable_event);
261 268
262 #if defined(ENABLE_PLUGINS) 269 #if defined(ENABLE_PLUGINS)
263 // PepperFlashSettingsManager::Client implementation. 270 // PepperFlashSettingsManager::Client implementation.
264 virtual void OnDeauthorizeContentLicensesCompleted(uint32 request_id, 271 void OnDeauthorizeContentLicensesCompleted(uint32 request_id,
265 bool success) override; 272 bool success) override;
266 #endif 273 #endif
267 274
268 #if defined (OS_CHROMEOS) 275 #if defined (OS_CHROMEOS)
269 void OnClearPlatformKeys(chromeos::DBusMethodCallStatus call_status, 276 void OnClearPlatformKeys(chromeos::DBusMethodCallStatus call_status,
270 bool result); 277 bool result);
271 #endif 278 #endif
272 279
273 // Removes the specified items related to browsing for a specific host. If the 280 // Removes the specified items related to browsing for a specific host. If the
274 // provided |origin| is empty, data is removed for all origins. The 281 // provided |origin| is empty, data is removed for all origins. The
275 // |origin_set_mask| parameter defines the set of origins from which data 282 // |origin_set_mask| parameter defines the set of origins from which data
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 465
459 scoped_ptr<TemplateURLService::Subscription> template_url_sub_; 466 scoped_ptr<TemplateURLService::Subscription> template_url_sub_;
460 467
461 // We do not own this. 468 // We do not own this.
462 content::StoragePartition* storage_partition_for_testing_; 469 content::StoragePartition* storage_partition_for_testing_;
463 470
464 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover); 471 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
465 }; 472 };
466 473
467 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 474 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698