Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/browser/resources/touch_ntp/tools/check

Issue 6661024: Use a specialized new tab page in TOUCH_UI builds (Closed) Base URL:
Patch Set: Fix some indentation issues and enable gjslist --strict mode to catch them automatically Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/touch_ntp/tools/check
diff --git a/chrome/browser/resources/touch_ntp/tools/check b/chrome/browser/resources/touch_ntp/tools/check
new file mode 100755
index 0000000000000000000000000000000000000000..5b1742bd8f09b950609e8d06d6c3ae65410157a3
--- /dev/null
+++ b/chrome/browser/resources/touch_ntp/tools/check
@@ -0,0 +1,58 @@
+# Copyright (c) 2008 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+# This script checks the touch_ntp code for common errors and style
+# problems using the closure compiler (jscompiler) and closure linter
+# (gjslint) - both of which must be on the path.
+# See and
+# for details on these tools.
+SOURCES="eventtracker.js touchhandler.js slider.js newtab.js grabber.js "
+# First run the closure compiler looking for syntactic issues.
+# Note that we throw away the output from jscompiler since it's use
+# is not yet common in Chromium and for now we want it to be an optional
+# tool for helping to find bugs, not something that actually changes
+# the embedded JavaScript (making it harder to debug, for example).
+# I used to run with '--warning_level VERBOSE' to get full type checking
+# but there are enough limitations in the language and compiler that
+# it doesn't seem worth the benefit (spent more time trying to apease
+# the compiler and reviewers of my code than the compiler saved me).
+# Enable support for property get/set syntax as added in ecmascript5.
+# Note that this requires a build of JSCompiler that is newer than
+# Feb 2011.
+CARGS+=" --js_output_file /dev/null"
+for S in $SOURCES tools/externs.js; do
+ CARGS+=" --js $S"
+cd `dirname $0`/..
+echo jscompiler $CARGS
+jscompiler $CARGS || exit 1
+# Now run the closure linter looking for style issues.
+# GJSLint can't follow the more concice syntax for prototype members and
+# complains about missing @this annotations (filed as bug 4073735). To
+# cope for now I just just off all missing-JSDoc warnings.
+# Verify extra rules like spacing and indentation
+LARGS+=" --strict"
+# Might as well check the bit of JS we have embedded in HTML too
+LARGS+=" --check_html newtab.html"
+echo gjslint $LARGS
+gjslint $LARGS || exit 1
« no previous file with comments | « chrome/browser/resources/touch_ntp/standalone/youtube-icon.png ('k') | chrome/browser/resources/touch_ntp/tools/externs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698