Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7825)

Unified Diff: chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html

Issue 666073005: Hotword Audio Verification App: UI polishes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add back is=action-link I accidently removed when merging Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
diff --git a/chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html b/chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
index a7c0871d93a8f1dcaf89109c9ec4e03c518d0da5..7873c1d939b5b026518d60b0a4f326259df07e5f 100644
--- a/chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
+++ b/chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html
@@ -2,13 +2,13 @@
<div class="mic"></div>
<div class="container">
<div class="header">
- <span class="close"></span>
+ <span id="speech-training-close-button" class="close"></span>
Dan Beam 2014/10/27 16:10:33 nit: try not to imply tag names or control types i
kcarattini 2014/10/27 23:20:10 Done.
<div class="header-text">
<div class="v-spacing-for-no-subheading"></div>
<h1>Let's train your Chromebook</h1>
</div>
</div>
- <div id="st-training" class="content">
+ <div id="speech-training-training" class="content">
Dan Beam 2014/10/27 16:10:33 awkward but consistent I guess (-training-training
kcarattini 2014/10/27 23:20:10 Yes. Going for consistency here.
<div class="col-2">
To help Google respond to you and for reliable and easy access to
voice search, you need to teach Google the sound of your voice.
@@ -32,7 +32,8 @@
</div>
</div>
<div class="buttonbar">
- <button id="st-cancel-button">CANCEL</button>
+ <button id="speech-training-cancel-button"
+ class="finish-button">CANCEL</button>
</div>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698